Closed Bug 133794 Opened 23 years ago Closed 23 years ago

Update the About page to Mozilla 1.0 Release Candidate 1, user agent to rv:1.0rc1

Categories

(SeaMonkey :: Build Config, defect, P1)

Product:
SeaMonkey
Component:
Build Config
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: lpham, Assigned: leaf)

References

Details

Attachments

(2 files, 2 obsolete files)

update rv: portion of user agent to 1.0rc1
(deleted), patch
scc
: review+
scc
: superreview+
Details | Diff | Splinter Review
oops. print out user agent underneath hardcoded link.
(deleted), patch
granrosebugs
: review+
granrosebugs
: superreview+
granrosebugs
: approval+
Details | Diff | Splinter Review
Mozilla 1.0 RC1 needs to update the About page to display "Mozilla 1.0 RC1". This is the only change on MOZILLA_1_0_0_BRANCH in term of versioning. Leaf will contact Asa to confirm the name before updating the About page.
Keywords: nsbeta1
Target Milestone: --- → mozilla1.0
Keywords: nsbeta1 → nsbeta1+
Changed the keyword to mozilla1.0 (requested by Asa)
Keywords: nsbeta1+ → mozilla1.0
Keywords: mozilla1.0 → mozilla1.0+
must have. mozilla1.0+
Blocks: 134771
Severity: normal → blocker
Priority: -- → P1
Blocks: 136189
IMHO, the about page belongs at about:mozilla replacing the worthless book of mozilla easter egg. about: should lead nowhere.
this bug is only about updating the about page to read Mozilla 1.0 RC1. Period. No user agent updates, no easter eggs, no nothing. This is a very boring bug with no discussion required.
Status: NEW → ASSIGNED
I'll make a file with the other locales' patches. Index: about.html =================================================================== RCS file: /cvsroot/mozilla/xpfe/global/resources/locale/en-US/about.html,v retrieving revision 1.13.2.1 diff -u -r1.13.2.1 about.html --- about.html 10 Apr 2002 03:44:37 -0000 1.13.2.1 +++ about.html 10 Apr 2002 22:00:28 -0000 @@ -68,16 +68,8 @@ <td id="mozver"> <h1> -<a id="mozlink" href="http://www.mozilla.org/releases/">Mozilla </a> +<a id="mozlink" href="http://www.mozilla.org/releases/">Mozilla 1.0RC1</a> </h1> -<script type="application/x-javascript"> - // using try..catch to handle empty useragents and other cases where the regex fails to apply - try { - document.getElementById("mozver").appendChild(document.createTextNode(navigator.userAgent)); - document.getElementById("mozlink").firstChild.appendData(navigator.userAgent.match(/rv:([^;)]+)/)[1]); - } - catch (e) {} -</script> </td> </tr>
nevermind; the other locales aren't checked in. i'll stick the comment/patch into a file for attachment.
fishin for a review and approval
Comment on attachment 78627 [details] [diff] [review] hardcode 1.0RC1 in about.html. add new release notes page. ><HTML><HEAD/><BODY><PRE>Index: about.html >=================================================================== >RCS file: /cvsroot/mozilla/xpfe/global/resources/locale/en-US/about.html,v >retrieving revision 1.13.2.1 >diff -u -r1.13.2.1 about.html >--- about.html 10 Apr 2002 03:44:37 -0000 1.13.2.1 >+++ about.html 10 Apr 2002 22:00:28 -0000 >@@ -68,16 +68,8 @@ > > <td id="mozver"> > <h1> >-<a id="mozlink" href="http://www.mozilla.org/releases/">Mozilla </a> >+<a id="mozlink" href="http://www.mozilla.org/releases/mozilla1.0/">Mozilla 1.0RC1</a> > </h1> >-<script type="application/x-javascript"> >- // using try..catch to handle empty useragents and other cases where the >regex fails to apply >- try { >- >document.getElementById("mozver").appendChild(document.createTextNode(navigator.userAgent)); >- >document.getElementById("mozlink").firstChild.appendData(navigator.userAgent.match(/rv:([^;)]+)/)[1]); >- } >- catch (e) {} >-</script> > </td> > > </tr> > > ></PRE></BODY></HTML>
Attachment #78627 - Attachment description: hardcode 1.0RC1 in about.html → hardcode 1.0RC1 in about.html. add new release notes page.
do you want to take out the javascript or just comment it out so we can put it back for future 1.0 releases?
i was going to use cvs to revert to the script, but commenting out is probably safer.
bug cleanup - all leaf's bugzilla bugs should be assigned to leaf@mozilla.org (not leaf@netscape.com), now and any future bugs created. this should be a one time change, apologies for the spam.
Assignee: leaf → leaf
Status: ASSIGNED → NEW
comment out the script, update release notes string.
Attachment #78627 - Attachment is obsolete: true
updating summary
Status: NEW → ASSIGNED
Summary: Update the About page to Mozilla 1.0 RC1 → Update the About page to Mozilla 1.0 Release Candidate 1, user agent to rv:1.0rc1
r/sr/a=blizzard
You no longer display the user-agent on about:, is that intentional?
Comment on attachment 78923 [details] [diff] [review] update rv: portion of user agent to 1.0rc1 sr=scc, and marking r=blizzard according to his comment #15, above.
Attachment #78923 - Flags: superreview+
Attachment #78923 - Flags: review+
Comment on attachment 78919 [details] [diff] [review] hardcode value of 1.0 Release Candidate 1 in about: page Is this normally how we handle a release (or release candidate)? The change looks reasonable and does what it says ... I'm just wondering if this is SOP. If it is, I'm ready to stamp my sr on it.
Comment on attachment 78919 [details] [diff] [review] hardcode value of 1.0 Release Candidate 1 in about: page I see now that this patch is really covered by bug #135855; should it therefor be marked obsolete here?
per Christians comment above at http://bugzilla.mozilla.org/show_bug.cgi?id=133794#c16 this patch needs to be tweaked so that the user agent is still displayed, it just doesn't get the version number from the user agent. My js is rusty but I think removing the second line: document.getElementById("mozlink").firstChild.appendData(navigator.userAgent.match(/rv:([^;)]+)/)[1]); will keep the user agent but let the version be hardcoded. scc - no, usually the about page and user agent update are two separate bugs, and we don't usually hard code the version number on the about page for mozilla releases. This is a special case since it's a pre-release. Also, what is the reference to 135855, that bug doesn't appear related?
cc'ing scc since he might be interested in the answer to his question :) granrose, yes, removing the line you mentioned should do it
Attachment #78919 - Attachment is obsolete: true
Comment on attachment 79323 [details] [diff] [review] oops. print out user agent underneath hardcoded link. looks good. r=granrose
Attachment #79323 - Flags: review+
Comment on attachment 79323 [details] [diff] [review] oops. print out user agent underneath hardcoded link. better, r=biesi
Comment on attachment 79323 [details] [diff] [review] oops. print out user agent underneath hardcoded link. In that case, I'll change mine to sr... adding a=asa since he gave us blanket approval for version updates for the 1.0 release.
Attachment #79323 - Flags: superreview+
Attachment #79323 - Flags: approval+
patch committed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified in 20020416 on linux for about page and user agent.
Status: RESOLVED → VERIFIED
adding branch verification keyword. This bug has been verified in a comment, just moving that to the keyword field.
Keywords: verified1.0.0
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: