Closed
Bug 1338016
Opened 8 years ago
Closed 8 years ago
hfsplus task installs clang from yum
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
In bug 1337980, we're going to switch docker-based toolchain tasks to run-task, which drops privileges, which means yum can't be used to install clang.
We'll use tooltool instead (for now)
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8835239 [details]
Bug 1338016 - Use clang from tooltool to build hfsplus.
https://reviewboard.mozilla.org/r/110930/#review112544
::: taskcluster/scripts/misc/build-hfsplus-linux.sh:12
(Diff revision 1)
> HOME_DIR=$WORKSPACE/build
> UPLOAD_DIR=$WORKSPACE/artifacts
>
> cd $HOME_DIR/src
>
> +TOOLTOOL_MANIFEST=browser/config/tooltool-manifests/linux64/clang.manifest
Doesn't this mean the task will download other things like rustc that aren't needed? Creating a separate manifest file that just has clang should be fine too.
Attachment #8835239 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8835239 [details]
> Bug 1338016 - Use clang from tooltool to build hfsplus.
>
> https://reviewboard.mozilla.org/r/110930/#review112544
>
> ::: taskcluster/scripts/misc/build-hfsplus-linux.sh:12
> (Diff revision 1)
> > HOME_DIR=$WORKSPACE/build
> > UPLOAD_DIR=$WORKSPACE/artifacts
> >
> > cd $HOME_DIR/src
> >
> > +TOOLTOOL_MANIFEST=browser/config/tooltool-manifests/linux64/clang.manifest
>
> Doesn't this mean the task will download other things like rustc that aren't
> needed? Creating a separate manifest file that just has clang should be fine
> too.
That's what happens with other toolchain tasks already, so I wouldn't worry too much about it. They're not built very often, and bug 1313111 will allow finer-grained dependencies.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/14f22ecd79f8
Use clang from tooltool to build hfsplus. r=mshal
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•