Chrome: border and outline colors are black Edge: border color inherits, outline color is "invert"

I think the right fix here is adding "color:unset" to the rules we changed in bug 605985, even though it doesn't match Chrome. It matches Edge in spirit though, even if not literally. It's the same behavior as a plain inline element has in both UAs...

Let's fix this while we're here.

Comment on attachment 8835808 [details] [diff] [review] fix Review of attachment 8835808 [details] [diff] [review]: ----------------------------------------------------------------- Consider adding a "!=" testcase to ensure that these form controls do render differently if you explicitly set the "color" property **on them** (rather than on their parent). ::: layout/style/res/forms.css @@ +611,5 @@ > input[type="radio"], > input[type="checkbox"] { > inline-size: 13px; > block-size: 13px; > + color: -moz-FieldText; (Do we really need this custom bit for Android? Seems like it'd make just as much sense to have to same color behavior there -- i.e. seems like we could revert this change.)

(In reply to Daniel Holbert [:dholbert] from comment #4) > Consider adding a "!=" testcase to ensure that these form controls do render > differently if you explicitly set the "color" property **on them** (rather > than on their parent). Sorry, disregard this ^^ request. I momentarily forgot that "color" is inherited -- so "unset" here really means "inherit". (I was thinking it meant "initial", i.e. black, and that you were going for the Chrome behavior described in comment 0. And I wanted to be sure that explicitly-set-colors would still work.)

(In reply to Daniel Holbert [:dholbert] from comment #4) > (Do we really need this custom bit for Android? Seems like it'd make just > as much sense to have to same color behavior there -- i.e. seems like we > could revert this change.) I think I'll stick to the "keep Android as is when possible" line I've been following in recent checkbox/radio/'appearance' patches. It seems safer for now. We can address the Android mess in general later.

Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f12b7bd5460b Make <input type=checkbox/radio> with '-moz-appearance:none' have default border/outline color. r=dholbert https://hg.mozilla.org/integration/mozilla-inbound/rev/f755745fed6d Reftest.

https://hg.mozilla.org/mozilla-central/rev/f12b7bd5460b https://hg.mozilla.org/mozilla-central/rev/f755745fed6d