Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Description • 8 years ago

Follow up Bug 1268804 Comment 88.
Test test_interfaces, test_worker_interfaces, test_worker_interfaces on both http and https channel.

'So specifically, we should pull all the script out of test_interfaces and test_worker_interfaces and test_navigator out into external scripts.  Then we should have two versions of each test, one loaded over https and one not, linking to said external scripts.  Then we should have the test assertions assert that some things are visible only in the secure context version.'

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 2 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa750a5ca21ed49cd059e8cf8a7e833d84109562

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 4 • 8 years ago

Comment on attachment 8835881 [details] [diff] [review]
Bug 1338438 - Test interfaces on both http and https channels

Review of attachment 8835881 [details] [diff] [review]:
-----------------------------------------------------------------

https://treeherder.mozilla.org/#/jobs?repo=try&revision=050bf7ecac7982e70090784e658fc75e959ada1e

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 5 • 8 years ago

(In reply to Shawn Huang [:shawnjohnjr] from comment #4)
> Comment on attachment 8835881 [details] [diff] [review]
> Bug 1338438 - Test interfaces on both http and https channels
> 
> Review of attachment 8835881 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=050bf7ecac7982e70090784e658fc75e959ada1e

It looks good.

	Boris Zbarsky [:bzbarsky]
	Comment 6 • 8 years ago

Comment on attachment 8835881 [details] [diff] [review]
Bug 1338438 - Test interfaces on both http and https channels

Please use "hg copy" (followed by removal of the non-JS bits) to create the *.js files so we don't lose revision history.  That will also make it _much_ simpler to tell whether you're introducing any changes in the JS bits.  ;)

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 8 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01ed9679838c033d05462b8dcd2cf43a8a2dc84a

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 9 • 8 years ago

Comment on attachment 8836462 [details] [diff] [review]
Bug 1338438 - Test interfaces on both http and https channels

Review of attachment 8836462 [details] [diff] [review]:
-----------------------------------------------------------------

Hi bz,
Thanks for pointing out the problems. I've used 'hg copy' to create test_interfaces.js and test_navigator.js.

	Boris Zbarsky [:bzbarsky]
	Comment 10 • 8 years ago

Comment on attachment 8836462 [details] [diff] [review]
Bug 1338438 - Test interfaces on both http and https channels

Thank you, this is much easier to review.  ;)

>+++ b/dom/tests/mochitest/general/test_interfaces.html

So what you should probably do is have this test do:

  ok(!self.isSecureContext, "This test should not be running in a secure context");

in addition to loading test_interfaces.js.

>+++ b/dom/tests/mochitest/general/test_interfaces_secureContext.html

And this one should do:

  ok(self.isSecureContext, "This test should be running in a secure context");

>+++ b/dom/workers/test/test_navigator.html
>+++ b/dom/workers/test/test_navigator_secureContext.html

And here.  And maybe a followup to have the worker for this test check self.isSecureContext in the worker too?

>+++ b/dom/workers/test/test_worker_interfaces_secureContext.html

And for this one as well, test_worker_interfaces.js should be able make assertions about secure context state based on where it got loaded from.  Again, followup is ok for this part.

r=me

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 12 • 8 years ago

Followup: Bug 1339354

	Pulsebot
	Comment 13 • 8 years ago

Pushed by shuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1f71852f5f
Test interfaces on both http and https channels, r=bz

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 14 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6b1f71852f5f