Closed
Bug 1338449
Opened 8 years ago
Closed 8 years ago
Conformance: Atomics operations should use ToIndex, not ToInteger, to convert and range check indices
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
See https://github.com/tc39/ecma262/pull/811. We should wait for that PR to land but this is almost certainly a done deal.
See also bug 1317383, bug 1317382.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → lhansen
Assignee | ||
Comment 1•8 years ago
|
||
I think this is all that's needed. While the MIR nodes for the atomic operations use IntPolicy for this argument and in principle need to change, those nodes are only created if the input is already Int32, so we should be OK on that.
Attachment #8837997 -
Flags: review?(shu)
Comment 2•8 years ago
|
||
Comment on attachment 8837997 [details] [diff] [review]
bug1338449-use-toindex.patch
Review of attachment 8837997 [details] [diff] [review]:
-----------------------------------------------------------------
Could you write the test262 tests as well and upstream PR them?
Attachment #8837997 -
Flags: review?(shu) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #2)
>
> Could you write the test262 tests as well and upstream PR them?
I have done so.
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc0af6d26ce88ebb456d55e80a7f24f66fc6d87
Bug 1338449 - use ToIndex to convert TA indices for atomic operations. r=shu
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•