Arbitrary local files disclosure in input[webkitdirectory]
Categories
(Core :: Widget, defect, P2)
Tracking
()
People
(Reporter: qab, Assigned: pbz)
References
()
Details
(Keywords: csectype-disclosure, sec-moderate, stale-bug, Whiteboard: [adv-main85+])
Attachments
(5 files, 1 obsolete file)
Reporter | ||
Comment 1•8 years ago
|
||
Comment hidden (typo) |
Comment 3•8 years ago
|
||
Reporter | ||
Comment 4•8 years ago
|
||
Updated•8 years ago
|
Updated•8 years ago
|
Updated•8 years ago
|
Updated•8 years ago
|
Comment 5•8 years ago
|
||
Updated•8 years ago
|
Comment 6•8 years ago
|
||
Comment hidden (off-topic) |
Updated•8 years ago
|
Comment hidden (off-topic) |
Reporter | ||
Comment 9•8 years ago
|
||
Comment hidden (off-topic) |
Comment hidden (off-topic) |
Comment hidden (off-topic) |
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Updated•7 years ago
|
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Updated•7 years ago
|
Comment 17•7 years ago
|
||
Comment 19•7 years ago
|
||
Reporter | ||
Comment 20•7 years ago
|
||
Updated•7 years ago
|
Comment 21•6 years ago
|
||
Comment 23•4 years ago
|
||
Looks like on Windows you can require interaction with the view in the modal dialog before the OK button is enabled by passing FOS_OKBUTTONNEEDSINTERACTION
(which is listed as one of the relevant options on the doc site, but with no explanation, so I wonder when that got added and on what OSes it's supported...). That seems to wfm on win10.
However, even Edge does not appear to use it; it instead prompts for confirmation before uploading, as does Chrome - with a dialog that then defaults to [Cancel]
(despite the styling of the dialog buttons suggesting that "Upload" is the default, which is... weird.)
Dan, what do you think about doing the same?
Updated•4 years ago
|
Comment 25•4 years ago
|
||
Paul, do you have cycles to look at adding a confirmation dialog using the tab-modal dialog infrastructure to mimic Edge/Chrome? Looks like somewhere like https://searchfox.org/mozilla-central/rev/e1d1f043957191616721b9e8bf811c0aab8a203a/dom/html/HTMLInputElement.cpp#483 would work?
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 26•4 years ago
|
||
Assignee | ||
Comment 27•4 years ago
|
||
This also fixes an issue where MockFilePicker wouldn't set the mode correctly,
which caused it to always use "modeOpen". For this test we need to pass
"modeGetFolder" in order for the prompt to show.
Depends on D95324
Comment 28•4 years ago
|
||
Comment 29•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer?job_id=321917169&repo=autoland&lineNumber=5103
Backout: https://hg.mozilla.org/integration/autoland/rev/72c8c0774cee0aac6084838f837186f904f7bb52
Assignee | ||
Comment 30•4 years ago
|
||
Depends on D96526
Comment 31•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 32•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fa598dea0903
https://hg.mozilla.org/mozilla-central/rev/9515d8916527
https://hg.mozilla.org/mozilla-central/rev/7b898a8dac3c
Updated•4 years ago
|
Comment 33•4 years ago
|
||
Comment 34•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Description
•