Closed
Bug 1338673
Opened 8 years ago
Closed 7 years ago
Implement GeckoActivityStatus in FxAccountStatusActivity
Categories
(Firefox for Android Graveyard :: Settings and Preferences, defect)
Tracking
(firefox54 affected)
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | affected |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(2 obsolete files)
Compare the failed attempt from bug 1336734 (https://reviewboard.mozilla.org/r/110172/diff/2/).
This requires either some sort of modification to our build system, so the compiler can find GeckoActivityStatus and GeckoApplication (which live in android/base) when building the FxAccountStatusActivity (which lives under android/services), or else us completely switching over to Gradle builds, where this "just works".
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
This is do-able, but not trivial. There are examples of sharing pieces in the tree; see https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build?q=path%3Aandroid%2Fbase%2Fmoz.build&redirect_type=single#39. However, it requires a lot of discipline to minimize the shared code, and might not be possible for something so tied to the Fennec Java code.
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks for the hint. I'll leave that for another day, but it might be doable if I split out onActivityPause/Resume into a separate interface, since that's the only bit of GeckoApplication I'm really interested in here.
|
|
Assignee | |
Comment 5•8 years ago
|
||
Yup, splitting those two functions into their own interface and moving that into a JAR that is accessible for android/services as well works.
Assignee: nobody → jh+bugzilla
No longer depends on: gradle-automation
|
|
Assignee | |
Comment 6•7 years ago
|
||
No longer needed because of bug 1346413.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8836231 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8836232 -
Attachment is obsolete: true
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•