Gabriele Svelto [:gsvelto] Reporter
	Description • 8 years ago

+++ This bug was initially created as a clone of Bug #1310703 +++

The crashreporter client is not currently covered by any tests IIRC; mostly because we'd have to interact with the UI to test it. Since we've added the ability to send crash pings straight from it, it would be convenient to be able to test this functionality starting from the actual crash and ending with receiving the ping.

To implement this we might add a special mode to the crashreporter client that prevents it from opening the UI but executes the rest of the code nonetheless; this would make testing via xpcshell rather easy.

	(not currently active) Ted Mielczarek
	Comment 1 • 8 years ago

We've had bug 379290 open for a decade(!) Fixing that while you're at it would let us  write tests for submitting crashes from the crashreporter client, which is something we've broken in the past.

	Gabriele Svelto [:gsvelto] Reporter
	Comment 2 • 8 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> We've had bug 379290 open for a decade(!) Fixing that while you're at it
> would let us  write tests for submitting crashes from the crashreporter
> client, which is something we've broken in the past.

Hah! Thanks for pointing that out, so it's going to be the next bug on my chopping block :-)

	:Gijs (he/him)
	Comment 3 • 8 years ago

Either that or you could use a marionette test and actually interact with the UI. That should work for in-browser UI. You could even use 'only' a browser mochitest to check submissions from about:crashes (if we don't already?).

	Benjamin Smedberg
	Comment 4 • 8 years ago

Marionette may not be able to interact with the native crashreporter, but yeah a mnette test is probably the right general framework. And you can also implement a telemetry receiver server in mnette to check that the pings are sent properly. See jdorlus' work in bug 1301781 and bug 1301776.

	Gabriele Svelto [:gsvelto] Reporter
	Comment 5 • 8 years ago

I don't think that marionette works with the crashreporter but I'm no expert so I'll have to double-check that.