Closed
Bug 1339674
Opened 8 years ago
Closed 8 years ago
stylo: update glue to set transform-box as a StyleGeometryBox.
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: u459114, Assigned: u459114)
References
Details
Attachments
(2 files)
Bug 1335876 does some refactoring of how computed transform-box values are stored. stylo glue side change is needed
Hi Manish, heycam said I may ask help from you. Could you handle the stylo glue code for this change?
I changed type of mTransformBox from uint8_t to StyleGeometryBox(similar to the change in bug 1336905) and stylo build break
Flags: needinfo?(manishearth)
|
||
Comment 2•8 years ago
|
||
I think the fix for this landed in a separate bug? I'm not sure now, sorry, missed this.
Flags: needinfo?(manishearth)
Yes, it still is. I will handle this one and bug 1340044, which is depend on this one.
Flags: needinfo?(cku)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Attachment #8847948 -
Flags: review?(cam)
Attachment #8847949 -
Flags: review?(cam)
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847948 [details]
Bug 1339674 - Part 1. Update glue to clip-path.
https://reviewboard.mozilla.org/r/120886/#review122838
Attachment #8847948 -
Flags: review?(cam) → review+
|
|
||
Comment 9•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847949 [details]
Bug 1339674 - Part 2. Update glue to transform-box.
https://reviewboard.mozilla.org/r/120888/#review122840
Attachment #8847949 -
Flags: review?(cam) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 12•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•