Split GeckoEditable into parent and child classes, with the parent class living inside the main process, and the child class living inside the main process and any child content processes.

Specify a list of AIDL files for GeckoView so we can include AIDLs from multiple packages, and not just those from the org.mozilla.gecko.process package.

Add IGeckoEditableParent.aidl and IGeckoEditableChild.aidl for two-way communication between the parent, which lives in the main process, and the child, which lives in the main process or a child content process.

Auto-generate native constants for the constants in GeckoEditableClient, instead of keeping a separate set of constants in native code.

Add the GeckoEditableChild class, which is currently only used in the main process as the interface between the native nsWindow and GeckoEditable. Eventually, it will be expanded to child content processes as the interface between the native PuppetWidget and main process GeckoEditable.

Make calls to GeckoEditableChild from GeckoEditable, and remove code that exists in GeckoEditableChild from GeckoEditable.

Add a convenience function for getting the C++ object that is the target of the native call.

Make nsWindow and GeckoEditableSupport use GeckoEditableChild for communication. nsWindow still keeps a reference to GeckoEditable for switching views.

Comment on attachment 8840573 [details] [diff] [review] 1. Support compiling GeckoView aidl from multiple packages (v1) Review of attachment 8840573 [details] [diff] [review]: ----------------------------------------------------------------- Sure.

Comment on attachment 8840596 [details] [diff] [review] 7. Use GeckoEditableChild from native code (v1) Review of attachment 8840596 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/android/GeckoEditableSupport.h @@ +130,5 @@ > { > + using GES = GeckoEditableSupport; > + return Base::lambda.IsTarget(&GES::OnKeyEvent) || > + Base::lambda.IsTarget(&GES::OnImeReplaceText) || > + Base::lambda.IsTarget(&GES::OnImeUpdateComposition) ? Can you add parentheses for readability?

Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/952cd4007da7 Split GeckoEditable into parent and child classes; r=nalexander r=esawin r=snorp