Closed Bug 1339708 Opened 8 years ago Closed 8 years ago

SUMO on lithium contribute.json

Categories

(support.mozilla.org - Lithium :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
2017q1

People

(Reporter: rolandtanglao, Assigned: rolandtanglao)

References

Details

(Whiteboard: [1st2weeks] [li-00134461])

Attachments

(1 file, 1 obsolete file)

see attached contribute.json for the support.mozilla.org aka SUMO new platform, lithium
april or jonathan, i don't think we need your approval but if one of you could take a quick look by Thursday Feb 16, 2017 that would be wonderful!
Flags: needinfo?(april)
Roland: I looked it over briefly and have a couple comments... 1.) The indentation and new-lines on the document seem a little inconsistent making it slightly hard to read (this was when viewing with Firefox). Ideally, the formatting would be similar to this => https://wiki.mozilla.org/Security/Guidelines/Web_Security#contribute.json 2.) I double checked the required keys from https://wiki.mozilla.org/Security/Guidelines/Web_Security#contribute.json and it looks like you have all of them, so you should be good there.
Flags: needinfo?(jclaudius)
(In reply to Jonathan Claudius [:claudijd] (use NEEDINFO) from comment #2) > Roland: I looked it over briefly and have a couple comments... > > 1.) The indentation and new-lines on the document seem a little inconsistent > making it slightly hard to read (this was when viewing with Firefox). > Ideally, the formatting would be similar to this => > https://wiki.mozilla.org/Security/Guidelines/Web_Security#contribute.json > 2.) I double checked the required keys from > https://wiki.mozilla.org/Security/Guidelines/Web_Security#contribute.json > and it looks like you have all of them, so you should be good there. ok, great i'll fix the indentation and get the lithium folks to add this file!, thanks :claudijd, i will un-needinfo :april now
Flags: needinfo?(april)
Looks good to me as well, with formatting fixes. Thanks!
Attached file SUMO lithium contribute.json (deleted) —
fixed the indentation as per jonathan and april's feedbacks in comment 2 and comment 4
Attachment #8837444 - Attachment is obsolete: true
scott or tyson or other lithium employee: Could one of you please upload contribute.json (attached to this bug as https://bugzilla.mozilla.org/attachment.cgi?id=8837701 ) to the root directory of support.mozilla.org (or show me how to do this?)? more background on contribute.json: https://wiki.mozilla.org/Security/Guidelines/Web_Security#contribute.json This is needed as part of our observatory security audit for support.mozilla.org : https://observatory.mozilla.org/analyze.html?host=support.mozilla.org
Flags: needinfo?(tyson.nunemacher)
Flags: needinfo?(scott.riley)
Whiteboard: [1st2weeks] → [1st2weeks] [li-00134461]
added whiteboard "[li-00134461]" for lithium support case 00134461
this is being deployed tonight thu feb 23, 2017 per comment copied and pasted from case 00134461, http://supportcases.lithium.com/50061000009MCTs, : Created By: Kris Stewart (2/23/2017 5:50 PM) Hi Roland, The change has been scheduled to be deployed to production during tonight's maintenance window. I'll follow up tomorrow morning to verify that the file is live. Best regards, Kris
Flags: needinfo?(tyson.nunemacher)
Flags: needinfo?(scott.riley)
assigning myself the bug to verify that it worked on production on monday feb 27, 2013
Assignee: nobody → rtanglao
Flags: needinfo?(rtanglao)
seems like it is working since it now gets a checkmark and "Contribute.json implemented with the required contact information", thanks lithium! yay :-) !
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(rtanglao)
Resolution: --- → FIXED
Component: Lithium Migration → General
Product: support.mozilla.org → support.mozilla.org - Lithium
Target Milestone: --- → 2017q1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: