Closed
Bug 1339800
Opened 8 years ago
Closed 7 years ago
Intermittent devtools/client/inspector/test/browser_inspector_highlighter-zoom.js | div margin point p2 x coordinate is correct - Got 1247, expected 1264
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(firefox52 unaffected, firefox53 unaffected, firefox54 fixed, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
firefox58 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: pbro)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing])
Attachments
(2 files)
Comment 1•8 years ago
|
||
This failure seems to happen on windows and linux, e10s only. It just started, but is very frequent today.
:gl -- Can you find someone to look at this?
Flags: needinfo?(gl)
Comment 2•8 years ago
|
||
Actually, now I see this test was updated just before it started failing, in https://hg.mozilla.org/integration/autoland/rev/07de05d8060cb97df8df4aaf371b7f23da4b46cb / bug 1312103.
Blocks: 1312103
Flags: needinfo?(gl) → needinfo?(zer0)
Comment hidden (Intermittent Failures Robot) |
Comment 4•8 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #2)
> Actually, now I see this test was updated just before it started failing, in
> https://hg.mozilla.org/integration/autoland/rev/
> 07de05d8060cb97df8df4aaf371b7f23da4b46cb / bug 1312103.
I'm taking a look. I'll try to reproduce on some VM – I'm on OSX. Unfortunately it seems that it has nothing to do with the test per se, but with the underling changes we made.
Flags: needinfo?(zer0)
Updated•8 years ago
|
Assignee: nobody → zer0
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 8•8 years ago
|
||
this error went away magically on the 17th :)
marking as fixed, but feel free to reopen if needed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Updated•8 years ago
|
Whiteboard: [stockwell unknown]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 24•7 years ago
|
||
I think I know why this fails intermittently: when you zoom in, the highlighter doesn't immediately update to cover the whole element. When I do it locally, I can see it updating in 2 steps. It grows to mostly cover the element at step 1, except a small portion on the right side. And then in a second step it updates to grow and cover the whole element.
So it's correct in the end, but depending on how the test runs, there may be cases where we check the size of the highlighter too soon, before it does step 2.
We should either make the test wait, or find out why the highlighter zooms this way. It almost looks to me like it's making space for a scrollbar that's not there.
Assignee | ||
Comment 25•7 years ago
|
||
This is what I meant with my previous comment. You can see in this gif that when the browser content is zoomed to 110%, the highlighter updates twice, and at first isn't big enough.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: zer0 → pbrosset
Assignee | ||
Comment 27•7 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment 29•7 years ago
|
||
mozreview-review |
Comment on attachment 8918845 [details]
Bug 1339800 - Toggle the highlighter between each test case;
https://reviewboard.mozilla.org/r/189706/#review195688
Attachment #8918845 -
Flags: review?(gl) → review+
Comment 30•7 years ago
|
||
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ba66e0d82a0
Toggle the highlighter between each test case; r=gl
Comment 31•7 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 8 years ago → 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•7 years ago
|
Whiteboard: [stockwell unknown] → [stockwell fixed:timing]
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•