Closed
Bug 1340135
Opened 8 years ago
Closed 8 years ago
Permission pop-up does not display the correct word for the update button when background update is prompted.
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | verified |
People
(Reporter: cbadescu, Assigned: aswan)
References
Details
(Keywords: regression)
Attachments
(1 file)
[Affected versions]:
- Firefox 54.0a1 (2017-02-16)
[Affected platforms]:
- Windows 7 64-bit
- Ubuntu 16.04 32-bit
[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Create xpinstall.signatures.dev-root and set it to true.
4.Change extensions.update.background.url to point to dev server and set the update interval (extensions.update.interval) to “1”.
5.Install the first version 1.4 of the following webextension: https://addons-dev.allizom.org/en-US/firefox/addon/permissionsall02-14-17-1-0/versions/
6.Restart the browser
[Expected results]:
- The word “Update” is displayed for the update button when permission pop-up is prompted in the web page.
[Actual results]:
- The word “Add” is displayed for the update button when permission pop-up is prompted in the web page.
[Regression range]
Last good build: f505911eb333d5ae8c2bf5c44f7b85add6450b53
First bad build: 70debab476881121ddfe92fc60c80cfae0a63bc7
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f505911eb333d5ae8c2bf5c44f7b85add6450b53&tochange=70debab476881121ddfe92fc60c80cfae0a63bc7
[Additional notes]:
- This issue reproduces constantly.
- Here is a video of this issue https://www.screencast.com/t/i3raFZNPgzT and a screenshot https://www.screencast.com/t/irtKRstQaIuF
I suspect that this issue was regressed by Bug 1336085.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aswan
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
I'm not sure what to do about testing here, this is about the contents of strings in the UI which we don't explicitly test anywhere else...
Assignee | ||
Updated•8 years ago
|
Attachment #8838235 -
Flags: review?(rhelmer)
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8838235 [details]
Bug 1340135 Use the right strings for permission update notifications
https://reviewboard.mozilla.org/r/113196/#review115088
Attachment #8838235 -
Flags: review?(rhelmer) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3519eae484c0
Use the right strings for permission update notifications r=rhelmer
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
This issue is verified as fixed on Firefox 54.0a1 (2017-02-24)under Wind 7 64-bit and Ubuntu 16.04 32-bit
The word “Update” is displayed for the update button when permission pop-up is prompted in the web page.
Here is a screenshot:https://www.screencast.com/t/4wxMwvIVsD1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•