Closed
Bug 1340445
Opened 8 years ago
Closed 7 years ago
stylo: use DOM slots for EffectSet
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
INVALID
People
(Reporter: boris, Assigned: boris)
References
Details
According to [1] and Bug 1340340 Comment 9, we should use DOM slots for EffectSet on stylo, instead of node properties. [1] https://public.etherpad-mozilla.org/p/stylo-animation
Assignee | ||
Updated•8 years ago
|
Comment 1•8 years ago
|
||
Note that AnimationCollection (which is used for CSS animations/transitions) also uses nsINode property.
Assignee | ||
Updated•8 years ago
|
Priority: -- → P3
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
DOM slot: http://searchfox.org/mozilla-central/rev/12cf11303392edac9f1da0c02e3d9ad2ecc8f4d3/dom/base/FragmentOrElement.h#245-253
Comment 3•8 years ago
|
||
FYI this may or may not be necessary, depending on the outcome of the discussion at in bug 1340340 comment 37.
Comment 4•8 years ago
|
||
As far as I can tell, for CSS Animtions/Transitions we need this since an EffectSet is created during the traversal when we set animation style property, and the newly created EffectSet is immediately used for calculating animation styles.
Comment 5•8 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #4) > As far as I can tell, for CSS Animtions/Transitions we need this since an > EffectSet is created during the traversal when we set animation style > property, and the newly created EffectSet is immediately used for > calculating animation styles. Could we create it, but use a SequentialTask to attach it to the node? I don't know if it would be practical, but we should at least consider it.
Comment 6•8 years ago
|
||
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #5) > (In reply to Hiroyuki Ikezoe (:hiro) from comment #4) > > As far as I can tell, for CSS Animtions/Transitions we need this since an > > EffectSet is created during the traversal when we set animation style > > property, and the newly created EffectSet is immediately used for > > calculating animation styles. > > Could we create it, but use a SequentialTask to attach it to the node? I > don't know if it would be practical, but we should at least consider it. Oh neat. I am not sure how hard it is but I guess we can.
Updated•7 years ago
|
Priority: P3 → --
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Priority: P3 → --
Comment 7•7 years ago
|
||
We decided not to take this approach but to rely on updating the data stored in node properties outside the parallel traversal in PreTraverse / SequentialTasks.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•