Closed
Bug 1340752
Opened 8 years ago
Closed 5 years ago
Lock with strike-through is shown on pages with an insecure non-login form submission
Categories
(Toolkit :: Password Manager, defect, P2)
Tracking
()
People
(Reporter: MattN, Unassigned)
References
()
Details
(Keywords: regression, Whiteboard: [fxprivacy])
Reported by Matthew Kogan from bug 1339059 comment #3
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131
Steps to reproduce:
Open http://www.huffingtonpost.co.uk/
Actual results:
No console warning about insecure logins but the address bar shows a lock with a strike-through.
Expected results:
No lock with a strike-through since there isn't a *login* form on the page.
Reporter | ||
Comment 1•8 years ago
|
||
The problem is that the ad network is auto-submitting a hidden form (that doesn't have login fields) but bug 1166947 introduced a regression that caused form submissions to cause a form to be added to `loginFormRootElements` for the document state from `earlyformsubmit` even if they don't contain login fields. `_detectInsecureFormLikes` uses `loginFormRootElements` to know if there are login forms present.
status-firefox53:
--- → affected
status-firefox54:
--- → affected
status-firefox-esr52:
--- → affected
Reporter | ||
Comment 2•8 years ago
|
||
I see twitter is doing this on the page along with huffingtonpost itself along with another ad network I saw do this earlier on the page so I've seen three hidden form submissions on this URL alone.
<form style="display:none;" class="_hp_xd_elements" id="_xd_form_id_1487381850950" name="_xd_form_1487381850950" action="http://www.huffingtonpost.com/users/provider/xd_handler.php" target="_xd_frame_1487381850950" method="POST"><input name="site" value="uk" type="hidden"><input name="sync" value="local" type="hidden"></form>
Comment 3•8 years ago
|
||
This situation underlines a deeper issue; that HTTPS pages can contain data from multiple sources, yet the 'padlock' info lists only the primary source.
Surprisingly, provided that the third-party data is covered by *ANY* SSL certificate, not necessarily the declared one, then no warning will be shown.
Yet, third party data is far more likely to be a source of security issues such as Trojans or MITM attacks.
Seems to me that if the padlock states:
Data is secured by Verisign
Content is provided by [whatever.trustedsite.com]
Then that must be true all of the time.
-Possibly a separate issue but thought it was relevant here.
Comment 4•8 years ago
|
||
We don't have then plan for 51 dot release. Mark 51 won't fix.
Updated•8 years ago
|
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Comment 5•8 years ago
|
||
Mass wontfix for bugs affecting firefox 52.
Comment 6•8 years ago
|
||
This was marked as a P1 bug back in early March but hasn't seen any activity since. Is this something we should continue tracking or should we drop the priority?
Comment 7•7 years ago
|
||
Too late for 54, let's see if we can fix it in 55.
Reporter | ||
Comment 8•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> This was marked as a P1 bug back in early March but hasn't seen any activity
> since. Is this something we should continue tracking or should we drop the
> priority?
It should stay P1 for when Password Manager actually gets resourced.
Assignee: MattN+bmo → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(MattN+bmo)
This is a P1 bug without an assignee.
P1 are bugs which are being worked on for the current release cycle/iteration/sprint.
If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.
Keywords: stale-bug
Updated•7 years ago
|
status-firefox56:
--- → wontfix
status-firefox57:
--- → affected
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 11•5 years ago
|
||
Fixed by removing this UI in bug 1527828.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•