Closed
Bug 1341031
Opened 8 years ago
Closed 8 years ago
popup.xml: menupopup is not defined in `mousemove` handler for popup-scrollbars
Categories
(Toolkit :: XUL Widgets, defect)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
I'm working on enabling no-undef eslint rule for toolkit/ and I discovered this error:
/Users/mark/dev/gecko/toolkit/content/widgets/popup.xml
725:10 error 'menupopup' is not defined. no-undef (eslint)
This is in the `mousemove` handler for the popup-scrollbars.
It looks like the `menupopup.releaseCapture()` should be `this.releaseCapture()`.
I also wonder if this may have been part of the cause of the issues for bug 1332708.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8839148 [details]
Bug 1341031 - Fix releasing drag capture for popups.
https://reviewboard.mozilla.org/r/113868/#review115606
Thanks! Glad to see these rules catching real bugs!
Attachment #8839148 -
Flags: review?(mconley) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cec05d38d05
Fix releasing drag capture for popups. r=mconley
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•