Closed Bug 1341219 Opened 8 years ago Closed 8 years ago

Extend the expiry of the browser engagement scalar probes

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
1

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

All of the scalar probes defined in [1] are set to expire in Firefox 55. The next uplift (and version increase) is on the 6th of March, so we need to make a call on whether to extend their lifetime or not. Unfortunately the email notification mechanism for expired scalars is not yet in place (see bug 1306623). [1] - http://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Scalars.yaml
Points: --- → 1
Priority: -- → P2
Whiteboard: [measurement:client]
Thanks for flagging this Alessio! It has become clear that these are critical metrics. They are now being used for KPIs, so we need to remove any future expiration date on them. Rweiss will +1 this for sure. How do we go about this?
Flags: needinfo?(rweiss)
(In reply to brendan c from comment #1) > Thanks for flagging this Alessio! > > It has become clear that these are critical metrics. They are now being used > for KPIs, so we need to remove any future expiration date on them. Rweiss > will +1 this for sure. Nice! Just to be explicit about this, I'm talking about: - browser.engagement.* - browser.engagement.navigation.*
Tracking these measurements past 55 are high priority. We are also using them now as key metrics for tracking metrics such as heavy users. I endorse continued measurement. :Dexter, do we need to do more than indicate our positions on this bug?
Flags: needinfo?(rweiss) → needinfo?(alessio.placitelli)
Thanks Rebecca. I can provide a patch that extends the probe lifetime. Before doing that, I need to know: - What expiry version should I set? Brendan mentioned "never", is that so? - Does this patch need a data review (I think so). Who should I flag?
Flags: needinfo?(alessio.placitelli) → needinfo?(rweiss)
Priority: P2 → P1
Assignee: nobody → alessio.placitelli
:Dexter I would like to set this for forever. I'll flag :bsmedberg for data review.
Flags: needinfo?(rweiss) → needinfo?(benjamin)
Dexter, do you know if these all have automated tests to make sure they won't break?
Flags: needinfo?(benjamin) → needinfo?(alessio.placitelli)
Flags: needinfo?(benjamin)
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7) > Dexter, do you know if these all have automated tests to make sure they > won't break? We do have all these probes covered with mochitests: the browser_UsageTelemetry_* files that live in browser/modules/test (e.g. [1]). [1] - http://searchfox.org/mozilla-central/source/browser/modules/test/browser_UsageTelemetry.js
Flags: needinfo?(alessio.placitelli)
Attachment #8840422 - Flags: review?(benjamin)
Brendan, are you the person taking responsibility for permanently using these metrics?
Flags: needinfo?(benjamin) → needinfo?(bcolloran)
Sure, I can sign my name on the line if that is our current protocol. But I assert that these metrics are of broader organization importance, and that when I get hit by a bus they will still be needed -- it's really the FF product org as whole that should own them rather than one person. (But since one person is needed, that can be me)
Flags: needinfo?(bcolloran)
Benjamin, is there anything else that you need to move forward with this?
Flags: needinfo?(benjamin)
Comment on attachment 8840422 [details] Bug 1341219 - Set the browser engagement scalar probes to never expire. https://reviewboard.mozilla.org/r/114934/#review119274 Yes, the point is to identify the person who's responsible for this *now*. It's find to hand off that responsibility later. If you and your team decide that these are not a priority in the future, that's when you have a responsibility to file a bug and get them disabled.
Attachment #8840422 - Flags: review?(benjamin) → review+
Flags: needinfo?(benjamin)
Blocks: 1344985
Pushed by alessio.placitelli@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dd661394dc03 Set the browser engagement scalar probes to never expire. r=bsmedberg
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: