Closed
Bug 1341286
Opened 8 years ago
Closed 7 years ago
Permissions pop-up does not disappear after navigating to a new url
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
DUPLICATE
of bug 1340538
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | verified |
firefox54 | --- | verified |
People
(Reporter: vtamas, Unassigned)
References
Details
(Keywords: regression, Whiteboard: permissions)
Attachments
(1 file)
(deleted),
image/gif
|
Details |
[Affected versions]: Firefox 54.0a1 (2017-02-20) Firefox 53.0a2 (2017-02-20) [Affected platforms]: Windows 10 64-bit Ubuntu 16.04 32-bit [Steps to reproduce]: 1.Launch Firefox with clean profile. 2.Create extensions.webextPermissionPrompts and set it to true. 3.Create xpinstall.signatures.dev-root and set it to true. 4.Restart the browser. 5.Click on “+ Add to Firefox” button to install the following webextension: https://addons-dev.allizom.org/en-US/firefox/addon/promptablepermission5/ . 6.Type a new page address in the url bar. [Expected Results]: The page is redirected to the new URL and the permission doorhanger is no longer displayed. [Actual Results]: The new page is loaded while the permission pop-up is still displayed out of the browser. [Additional Notes]: - Ubuntu screenshot: https://www.screencast.com/t/m6fojNL0tZPp - I am attaching a video recorded on Windows 10.
Updated•8 years ago
|
Whiteboard: permissions
Comment 1•8 years ago
|
||
This is a consequence of the fix for bug 1334354. I haven't tested it but from looking at the code, it is consistent with how the pre-permissions add-ons notifications work as well. But moreover, I think it is our only reasonable option for fixing bug 1334354.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Comment 2•7 years ago
|
||
I am not sure this is a wontfix. Persisting the doorhanger when the user has navigated away to a different page is not great, particularly when the doorhanger is not even aligned at the right place (see attached gif) Markus, what are your thoughts?
Status: RESOLVED → REOPENED
Flags: needinfo?(mjaritz)
Resolution: WONTFIX → ---
Comment 3•7 years ago
|
||
Wow. Thank you for the needinfo kraj. That should not happen! As soon as the user actively confirms a new website the install should be canceled. Like install is canceled when I click on any link on the website that takes me to another page. Andrew, what can we do to resolve this?
Flags: needinfo?(mjaritz) → needinfo?(aswan)
Reporter | ||
Comment 4•7 years ago
|
||
Investigated further and noticed the following: - The install doorhanger also persists after navigating to a new url with extensions.webextPermissionPrompts set to false - Clicking “Install” button which appears in installation doorhanger for extensions.webextPermissionPrompts set to false does not install the extension: https://www.screencast.com/t/Yp2DjUABho0b - Clicking “Add” button which is displayed in installation pop-up for extensions.webextPermissionPrompts set to true, successfully installs the extension: https://www.screencast.com/t/IHEg27G8dbqt This issue seems to be regressed by Bug 1328304: Last good revision: 771f1590f03efec066b2118cad52f11fd17d43ce First bad revision: 785314dbec5772bc3b0f0bc18f6ab63fec750193 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=771f1590f03efec066b2118cad52f11fd17d43ce&tochange=785314dbec5772bc3b0f0bc18f6ab63fec750193
Blocks: 1328304
Keywords: regression
Comment 5•7 years ago
|
||
This will get fixed by 1340538 (there's still a slight flicker which I'm not a big fan of, so we might make a followup bug there).
Status: REOPENED → RESOLVED
Closed: 8 years ago → 7 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Flags: needinfo?(aswan)
Verified in 53 in the dupe.
You need to log in
before you can comment on or make changes to this bug.
Description
•