Closed
Bug 1341571
Opened 8 years ago
Closed 8 years ago
'ex' is not defined in TelemetryModules.jsm - logging would be incorrect
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
Bug 1330833 added TelemetryModules.jsm, in bug 1341029 I'm working on getting the no-undef rule for eslint enabled.
I've just noticed this issue:
toolkit/components/telemetry/TelemetryModules.jsm
92:59 error 'ex' is not defined. no-undef (eslint)
Looking at the code, I think the only effect of this is that the debug logging won't log the right messages.
|
||
Comment 1•8 years ago
|
||
Oh, how did I miss it? It should be `err` obviously.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8839856 [details]
Bug 1341571 - 'ex' is not defined in TelemetryModules.jsm.
https://reviewboard.mozilla.org/r/114448/#review115882
Thanks for fixing that!
Attachment #8839856 -
Flags: review?(alessio.placitelli) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c63fdfb7d873
'ex' is not defined in TelemetryModules.jsm. r=Dexter
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•