Comment on attachment 8840199 [details] Bug 1341928 - Tag the Geolocation test suite. https://reviewboard.mozilla.org/r/114698/#review118906 This looks fine to me, but try appeared to be _really_ unhappy with it?

(In reply to Josh Matthews [:jdm] from comment #2) > This looks fine to me, but try appeared to be _really_ unhappy with it? That's probably due to the try syntax I've used. Re-running everything to be 100% certain nothing breaks...

Sorry to bother you :KWierso but I need some input about this. I wanted to tag all the tests directly and indirectly related to Geolocation and, as you can see, I've used the "tags" property for that. Now, the question: have I made some mistake here or is it normal to get so much desperation out of treeherder when limiting the try runs with the "--tag" parameter in the try syntax?:)

I think the error you're getting is hidden in the log as "desktop_unittest.py: error: no such option: --tag" which looks very similar to bug 1336606.

(In reply to Wes Kocher (:KWierso) from comment #6) > I think the error you're getting is hidden in the log as > "desktop_unittest.py: error: no such option: --tag" which looks very similar > to bug 1336606. I see. So, as long as we don't trigger any try runs with the '--tag' parameter it should be fine to land this, right?

Would probably be worth doing a try run without the --tag parameter, but yeah.

Pushed by mdesimone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79103a5a95f0 Tag the Geolocation test suite. r=jdm