Closed
Bug 1342022
Opened 8 years ago
Closed 8 years ago
Remove useless a "using" declaration in WebrtcTelemetry.cpp
Categories
(Developer Infrastructure :: Source Code Analysis, defect, P3)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: l1peu2tout, Assigned: l1peu2tout)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Running some toolings, I found that an "using" declaration is useless.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8840406 -
Flags: review?(gfritzsche)
Updated•8 years ago
|
Assignee: nobody → l1peu2tout
Blocks: clang-based-analysis
Comment 2•8 years ago
|
||
Thanks for looking into those.
For straight-forward replacements like this, it would be more efficient to do multiple or all in one bug (i see e.g. bug 1342032).
This shouldn't need special review everywhere.
Flags: needinfo?(l1peu2tout)
Comment 3•8 years ago
|
||
Comment on attachment 8840406 [details] [diff] [review]
bug1342022.diff
Review of attachment 8840406 [details] [diff] [review]:
-----------------------------------------------------------------
This looks fine to me, thanks.
Attachment #8840406 -
Flags: review?(gfritzsche) → review+
Comment 4•8 years ago
|
||
No try push needed here.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11a711ac2407
Remove useless a "using" declaration in WebrtcTelemetry.cpp. r=gfritzsche
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•