I haven't changed the documentation at the beginning ("Returns an array of the modules loaded in the process...") as that one is meant to be more of a high level description. Do you prefer I change it as well?

(In reply to Marco Castelluccio [:marco] from comment #1) > I haven't changed the documentation at the beginning ("Returns an array of > the modules loaded in the process...") as that one is meant to be more of a > high level description. Do you prefer I change it as well? Just "Asynchronously get an array of ..."?

(In reply to Georg Fritzsche [:gfritzsche] from comment #2) > (In reply to Marco Castelluccio [:marco] from comment #1) > > I haven't changed the documentation at the beginning ("Returns an array of > > the modules loaded in the process...") as that one is meant to be more of a > > high level description. Do you prefer I change it as well? > > Just "Asynchronously get an array of ..."? OK!

Comment on attachment 8840415 [details] [diff] [review] Patch Review of attachment 8840415 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/nsITelemetry.idl @@ +199,1 @@ > * @throws NS_ERROR_FAILURE on failure. This seems a bit inconsistent. I see that this can: - throw if main thread init fails or this is built without MOZ_GECKO_PROFILER - resolve to a module array - reject with NS_ERROR_FAILURE We should at least document all those cases. Better: always return a promise and resolve/reject.

(In reply to Georg Fritzsche [:gfritzsche] from comment #4) > Comment on attachment 8840415 [details] [diff] [review] > Patch > > Review of attachment 8840415 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: toolkit/components/telemetry/nsITelemetry.idl > @@ +199,1 @@ > > * @throws NS_ERROR_FAILURE on failure. > > This seems a bit inconsistent. > I see that this can: > - throw if main thread init fails or this is built without MOZ_GECKO_PROFILER > - resolve to a module array > - reject with NS_ERROR_FAILURE > > We should at least document all those cases. Done. I haven't documented the possible (but really unlikely) failure to create the Promise, as discussed on IRC. > Better: always return a promise and resolve/reject. The creation of the promise is fallible by itself, so we can't do that.

Comment on attachment 8844407 [details] [diff] [review] Patch Review of attachment 8844407 [details] [diff] [review]: ----------------------------------------------------------------- Please change the commit message to report me as the reviewer.

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/25b6db4e4810 Fix documentation of getLoadedModules in nsITelemetry.idl. r=Dexter