Closed Bug 1342056 Opened 8 years ago Closed 8 years ago

[Non-e10s] Grid Inspector changes position after page refresh when page with grid is in iframe

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox51 unaffected, firefox52 affected, firefox53 affected, firefox54 affected)

RESOLVED DUPLICATE of bug 1312103
Tracking Status
firefox51 --- unaffected
firefox52 --- affected
firefox53 --- affected
firefox54 --- affected

People

(Reporter: bmaris, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

[Affected versions]: - latest Developer Edition 53.0a2 - Firefox 52 beta 8 [Unaffected versions]: - latest Nightly 54.0a1 [Affected platforms]: - Windows 10 64-bit - macOS 10.12.3 - Ubuntu 16.04 32-bit [Steps to reproduce]: 1. Start Firefox 2. Make sure e10s is disabled (where e10s is enabled by default just open a New Non-e10s window from Panel Menu) 3. Load the iframe containing a website using grid demo: https://goo.gl/SRfz8R - download and save on drive 4. Open inspector and activate Grid tool 5. Refresh the page [Expected result]: - Grid highlighter does not change position before is dismissed by the page refresh [Actual result]: - Grid highlighter changes position just before it's dismissed by the page refresh. [Regression range]: - This is not actually a regression since latest Nightly is not affected and only an uplift should be required Last good revision: 365ed2bc91f669d6a1bdbdd1c125bc01050409cc First bad revision: 2ae8554e0989e12e9ef5755a4171841b02df7f11 Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=365ed2bc91f669d6a1bdbdd1c125bc01050409cc&tochange=2ae8554e0989e12e9ef5755a4171841b02df7f11 Culprit: 2ae8554e0989 Panos Astithas — Don't autofocus buttons when about:certerror is embedded in an iframe (bug 1336352). r=nhnt11 [Additional notes]: - Gif showing the issue is attached. - Note that this does not reproduce on latest Nightly so, a possible quick fix to this would be to uplift bug 1336352 on 53 and 52 because it affects this feature. - I also marked 54 as affected since build from first bad is also Nightly 54 even though is an older build than today.
Attached image Gif showing the issue (deleted) —
And here is the .gif showing the issue.
Perhaps we should consider uplifting the fixes you have in this area?
Flags: needinfo?(zer0)
Flags: qe-verify+
Priority: -- → P3
Blocks: dt-grid
Blocks: 1333706
(In reply to Gabriel Luong [:gl][1 biz day review guarantee] (ΦωΦ) from comment #2) > Perhaps we should consider uplifting the fixes you have in this area? I think it would help, it's worth a try anyway (I'm referring of course on bug 1312103).
Flags: needinfo?(zer0)
Summary: [Non-e10s] Grid highlighter changes position after page refresh when page with grid is in iframe → [Non-e10s] Grid Inspector changes position after page refresh when page with grid is in iframe
Needs to be checked after Bug 1342310 lands.
Depends on: 1342310
Flags: needinfo?(jdescottes)
Actually just verified, this bug was fixed by Bug 1312103. I am closing this one as duplicate. If an uplift is needed, please request it in Bug 1312103.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(jdescottes)
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: