Closed Bug 1342142 Opened 8 years ago Closed 8 years ago

enable webextension permissions prompts by default

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
51 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: aswan, Assigned: aswan)

References

Details

(Whiteboard: [permissions] triaged)

Attachments

(2 files)

Bug 1342142 Part 2 Enable webextension permission prompts
(deleted), text/x-review-board-request
mossop
: review+
Details
Bug 1342142 Part 1 Toolkit test cleanups
(deleted), text/x-review-board-request
mossop
: review+
Details
This bug is to track all the blockers that need to be resolved before we can enable permissions prompts by default. Once we're ready, we need to set "extensions.webextPermissionPrompts" to true in firefox.js
Blocks: webext-permissions
Depends on: 1329884
Depends on: 1332061
No longer depends on: 1340501
Depends on: 1340501
No longer depends on: 1340531
No longer depends on: 1340471
Depends on: 1342896
Whiteboard: [permissions] triaged
No longer depends on: 1329884
Assignee: nobody → aswan
Attachment #8849672 - Flags: review?(dtownsend)
Attachment #8846198 - Flags: review?(dtownsend)
Comment on attachment 8849672 [details] Bug 1342142 Part 1 Toolkit test cleanups https://reviewboard.mozilla.org/r/122448/#review125072 ::: toolkit/mozapps/extensions/test/browser/browser_searching.js:555 (Diff revision 5) > list.ensureElementIsVisible(remoteItem); > > installBtn = get_install_button(remoteItem); > is(installBtn.hidden, false, "Install button should be showing before install"); > remoteItem.mAddon.install.addListener(listener); > + promiseNotification().then(() => {}); This looks like it doesn't do anything. What am I missing?
Comment on attachment 8846198 [details] Bug 1342142 Part 2 Enable webextension permission prompts https://reviewboard.mozilla.org/r/119300/#review125078
Attachment #8846198 - Flags: review?(dtownsend) → review+
Comment on attachment 8849672 [details] Bug 1342142 Part 1 Toolkit test cleanups https://reviewboard.mozilla.org/r/122448/#review125072 > This looks like it doesn't do anything. What am I missing? I probably could name things better, but `promiseNotification()` causes the notification to be accepted. It also returns a Promise in case the caller cares to know when that has happened. The `.then()` clause is pointless, I can remove it.
Comment on attachment 8849672 [details] Bug 1342142 Part 1 Toolkit test cleanups https://reviewboard.mozilla.org/r/122448/#review125086 r+ with the then clause removed then.
Attachment #8849672 - Flags: review?(dtownsend) → review+
Pushed by aswan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa49f7a3e67d Part 1 Toolkit test cleanups r=mossop https://hg.mozilla.org/integration/autoland/rev/9f93b4b4a7ca Part 2 Enable webextension permission prompts r=mossop
https://hg.mozilla.org/mozilla-central/rev/fa49f7a3e67d https://hg.mozilla.org/mozilla-central/rev/9f93b4b4a7ca
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Considering that all dependencies are verified and the webextension permissions pref is enabled by default, I am marking this bug as verified fixed on Firefox 55.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: