Closed
Bug 1342215
Opened 8 years ago
Closed 8 years ago
pageError stubs generation is incorrect
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
We set a listener for "pageError" but we don't remove them.
There is a `once: true` propertyas an option for addListener, but this isn't a standard addEventListener call, and this the once property doesn't do anything.
|
Assignee | |
Updated•8 years ago
|
Summary: pageError stubs generation is broken → pageError stubs generation is incorrect
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8840592 [details]
Bug 1342215 - Fix pageError stub generation.
https://reviewboard.mozilla.org/r/115054/#review116638
good catch!
Attachment #8840592 -
Flags: review?(jdescottes) → review+
Pushed by chevobbe.nicolas@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/647cbb760050
Fix pageError stub generation. r=jdescottes
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•