Closed
Bug 1342276
Opened 8 years ago
Closed 8 years ago
Enable display caret layers for webrender
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Start using WR to paint caret items.
Assignee | ||
Comment 1•8 years ago
|
||
Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=97d9d081b0f17297e265e7f3b77b037bc3e008fe
Attachment #8840970 -
Flags: review?(jmuizelaar)
Comment 2•8 years ago
|
||
Comment on attachment 8840970 [details] [diff] [review]
Enable caret layers in WR
Review of attachment 8840970 [details] [diff] [review]:
-----------------------------------------------------------------
Why does this get rid of the border layer pref?
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Comment on attachment 8840970 [details] [diff] [review]
> Enable caret layers in WR
>
> Review of attachment 8840970 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Why does this get rid of the border layer pref?
It was explicitly set to false when it didn't need to be since it's already default false in gfxPrefs.
Comment 4•8 years ago
|
||
(In reply to Mason Chang [:mchang] from comment #3)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> > Comment on attachment 8840970 [details] [diff] [review]
> > Enable caret layers in WR
> >
> > Review of attachment 8840970 [details] [diff] [review]:
> > -----------------------------------------------------------------
> >
> > Why does this get rid of the border layer pref?
>
> It was explicitly set to false when it didn't need to be since it's already
> default false in gfxPrefs.
But having it all.prefs makes it show up in about:config which is more convenient.
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8840970 -
Attachment is obsolete: true
Attachment #8840970 -
Flags: review?(jmuizelaar)
Attachment #8840987 -
Flags: review?(jmuizelaar)
Updated•8 years ago
|
Attachment #8840987 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/6237f9ee107b
Enable display caret layers for webrender. r=jmuizelaar
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 8•8 years ago
|
||
status-firefox54:
--- → fixed
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•