Closed
Bug 1342354
Opened 8 years ago
Closed 8 years ago
Add pref on/off switch for new bookmark features
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Firefox for Android Graveyard
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: cnevinchen, Assigned: cnevinchen)
References
Details
Attachments
(1 file)
We need a new pref in about:config for disable new bookmark features before development completed.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8841409 [details]
Bug 1342354 - Add pref pref on/off switch for new bookmark features.
https://reviewboard.mozilla.org/r/115632/#review117152
::: mobile/android/base/java/org/mozilla/gecko/home/BookmarksPanel.java:132
(Diff revision 1)
> });
>
> return view;
> }
>
> + private void getGeckoPreference() {
Maybe name this something like setupPrefHandler() or similar to make it more obvious?
Attachment #8841409 -
Flags: review?(ahunt) → review+
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
seems there is a open issue in mozreview, this need to be fixed before we can autoland this patch. Could you take a look, thanks!
Flags: needinfo?(cnevinchen)
Keywords: checkin-needed
|
||
Updated•8 years ago
|
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0b8279c5d55d
Add pref pref on/off switch for new bookmark features. r=ahunt
Keywords: checkin-needed
|
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
|
|
||
Updated•8 years ago
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•