STR 1) Open Preferences 2) Select Applications 3) Next to "Web Feed" select "Add Live Bookmarks to Nightly" -> It is correctly shown as selected. 4) Click on any other item 5) Click back on "Web Feed" Expected Results -> "Add Live Bookmarks to Nightly" remains displayed Actual Results -> "Preview in Nightly" is displayed -> Console message: "ReferenceError: internalMenuItem is not defined" This is a regression from bug 1294989 that I've found when working on enabling the no-undef rule.

Comment on attachment 8840893 [details] Bug 1342427 - Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". https://reviewboard.mozilla.org/r/115312/#review116808 We should probably have a test for this.

Comment on attachment 8840893 [details] Bug 1342427 - Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". Now with added unit test :-)

Comment on attachment 8840893 [details] Bug 1342427 - Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". https://reviewboard.mozilla.org/r/115312/#review117142 ::: browser/components/preferences/in-content/tests/browser_applications_selection.js:51 (Diff revision 3) > + win.document.getAnonymousElementByAttribute(feedItem, "class", "actionsMenu")); > + info("Got list after item was selected"); > + Assert.ok(list.selectedItem, "Should have a selected item."); > + Assert.equal(list.selectedItem.getAttribute("action"), > + Ci.nsIHandlerInfo.handleInternally, > + "Newly selected item should by the expected one."); s/should by/should be/

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84a017610f03 Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". r=jaws

I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=80463655&repo=autoland https://hg.mozilla.org/integration/autoland/rev/f30e28369136fcb28dddcd55a94d98e2816009e9

It appears that the test was getting the favicon for mibbit for building the menulist. I've changed it to a different menu list so that doesn't happen.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a88a6717a2b7 Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". r=jaws

Probably too late for Fx52 at this point, but were you thinking this should be uplifted or let it ride the trains?

Comment on attachment 8840893 [details] Bug 1342427 - Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". Approval Request Comment [Feature/Bug causing the regression]: Bug 1294989 [User impact if declined]: Strange effects if they have specific non-default settings in the application preferences. [Is this code covered by automated tests?]: This bug adds a test. [Has the fix been verified in Nightly?]: I've just verified it. [Needs manual test from QE? If yes, steps to reproduce]: See STR [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Fixes scope of variables, unit test covers the changes. [String changes made/needed]: None

Comment on attachment 8840893 [details] Bug 1342427 - Setting Web Feeds in Application Preferences to "Add Live Bookmarks" then reselecting it appears to revert to "Preview in Nightly". Odd. Let's fix it for 53 aurora. Thanks for including a new test!