Closed Bug 1342452 Opened 8 years ago Closed 8 years ago

frontend visual fix for the permissions panel

Categories

(WebExtensions :: Frontend, defect)

51 Branch
defect
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1329942

People

(Reporter: emanuela, Assigned: mstriemer)

References

Details

Attachments

(2 files)

Hi guys, some frontend enhancement here. 1) .addon-webext-perm-header should have font-size:1em (currently 1.3) 2) The ul #addon-webext-perm-list should have padding-inline-start: 15px (currently 40px) 3) Currently, the arrow panel has a lot element of space on the top and on the bottom. The structure was too complex for letting me play with the browser inspector. However, I think it makes sense to take a look at the work done for the permissions arrow panels for this matter. Attached how the arrow panel looks just applying the first two points.
If I understand what you're describing correctly, point 3 is bug 1329942 which mstriemer was looking at earlier this week.
(In reply to Andrew Swan [:aswan] from comment #1) > If I understand what you're describing correctly, point 3 is bug 1329942 > which mstriemer was looking at earlier this week. bug 1329942 may solve it, yes. Point 1 and 2 are still valid IMHO.
I'm going to look at getting my patch for bug 1329942 up for review today, I'll see about sneaking points 1 and 2 into it.
Assignee: nobody → mstriemer
Attached image permissions-alignment.png (deleted) —
With those values the alignment still looks a bit off to me. This is likely because I had to rework where the heading is placed to make the top alignment correct. I made a few versions and I'm guessing one of them is what we're looking for. As stated above the "it requires your permission to:" label bit is 1px off of the indent for the list (1px off). Should it be inline with the list 5px in (All 5px in) or inline with the list and heading (Left aligned) or only the list 5px indent (List 5px in)
Flags: needinfo?(emanuela)
I thought the attached image was the old one. It looks like we want left-aligned. I'll go with that.
Mark, yes! Much better! The version we're looking for is definitely left-aligned. It looks to me we still have quite a space below the list, there is something we can do for it?
Flags: needinfo?(emanuela) → needinfo?(mstriemer)
I was able to remove the extra spacing on the bottom. Duping with bug 1329942 since that one has the fix for this.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mstriemer)
Resolution: --- → DUPLICATE
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: