Closed
Bug 134248
Opened 23 years ago
Closed 23 years ago
Change in nsIIOServices extractUrlPart method: No longer returns start and end offsets of parts
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: cmanske, Assigned: cmanske)
References
Details
(Keywords: regression, Whiteboard: publish)
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
akkzilla
:
review+
kinmoz
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
Composer uses nsIIOServices::extractUrlPart() a lot. Interface change has
busted StripUsernamePassword(). We also need to drop out param objects to all
other calls to this.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Keywords: nsbeta1,
regression
Whiteboard: publish
Target Milestone: --- → mozilla1.0
|
||
Comment 2•23 years ago
|
||
Comment on attachment 76767 [details] [diff] [review]
Patch v1
r=brade
Attachment #76767 -
Flags: review+
|
|
Assignee | |
Comment 3•23 years ago
|
||
Look for ":" in case username is same as password
Attachment #76767 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•23 years ago
|
||
Take my time. Get it right.
Attachment #76770 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•23 years ago
|
||
Stupid notepad patch. wrong file last time.
Attachment #76775 -
Attachment is obsolete: true
|
||
Comment 6•23 years ago
|
||
Comment on attachment 76777 [details] [diff] [review]
Patch v4
r=akkana
You might consider putting the GetIoService call inside the if (atIndex > 0),
perhaps even inside the try in that if, since the IOService isn't actually used
otherwise. (You can have the r= either way, no need to submit another patch
for that if you decide to do it.)
Attachment #76777 -
Flags: review+
Comment on attachment 76777 [details] [diff] [review]
Patch v4
sr=kin@netscape.com
I like akk's suggestion to move the GetIOService() call into the try, just
before you use it.
Attachment #76777 -
Flags: superreview+
|
|
Assignee | |
Updated•23 years ago
|
No longer blocks: 134059
Whiteboard: publish → publish, FIX IN HAND, need approval
|
||
Comment 8•23 years ago
|
||
Comment on attachment 76777 [details] [diff] [review]
Patch v4
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76777 -
Flags: approval+
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: publish, FIX IN HAND, need approval → publish, FIX IN HAND, approved
|
|
Assignee | |
Comment 9•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: publish, FIX IN HAND, approved → publish
|
||
Comment 10•23 years ago
|
||
Charley, can you verify this bug and mar verified-fixed? thanks..
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•