Closed Bug 134274 Opened 23 years ago Closed 23 years ago

Mail password saved after exit in quick launch mode

Categories

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect, P1)

x86
Windows 2000

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: esther, Assigned: cavin)

References

Details

(Whiteboard: [adt1][ETA 04/05])

Attachments

(1 file)

Using build 20020328 on winxp, quick launch enabled, my imap password is remembered (doesn't show up in Password manager) after exiting and relaunching app. This happens even if I open another profile then go back to the one I use for daily use. 1. Have more than 1 profile 2. Launch a profile with an IMAP (haven't tried the other types of mail accounts yet) mail account. Login and give password (don't save it). 3. Read some mail and exit the app. 4. Open this profile again, one mail and click on a mail message. Result: I'm not asked for a password to read, get or send (my sent folder is designated as IMAP). Expected: To have to give a password for my IMAP account. 5. Exit and relaunch a different profile, read mail and exit. 6. Relauch my previous profile again, and open mail. Result: I'm not asked for a password to read, get or send mail.
Nomintaing because enabling Quick Launch does not tell the user specifically it will remember their password. Exit in previous builds meant you connection to your mail server was dropped. Exit with turbo on in some cases means the connection is still active resulting in no password needed.
Keywords: nsbeta1
This is probably a mail bug. Reassigning to Cavin. marking nsbeta1+ and [adt1]
Assignee: law → cavin
Keywords: nsbeta1nsbeta1+
Priority: -- → P1
Whiteboard: [adt1]
Target Milestone: --- → mozilla1.0
Cavin and I found a reproducible case. Start with Quick Launch Off. 1. Create a Profile and add an email account (I had my netscape dredd account added) 2. Log into that email account, and then turn on Quick Launch via Preferences|Advanced. 3. Exit the app you should see a dialog notifying you are in turbo mode 4. Launch the app again, create a new profile with the same mail account. 5. Log into that mail account, giving password, read a message Exit the app. 6. Launch the 1st profile again and go to mail clicking on a message Result: no password required Expected: should ask for a password 7. Exit and launch the 2nd profile 8. Go to mail, click on a message, Result: no password required Expected: should ask for a password
Whiteboard: [adt1] → [adt1][ETA 04/05]
I can reproduce the problem using the following steps as well: Profiles A1 and A2 have only one account with the same username, hostname and server type. 1. Login to profile A1 and turn on Quick Launch mode and exit. 2. Exit and run mail again with profile A2. 3. Exit and run mail again (the 3rd time) with profile A2. No password prompt for 3rd run of the mail program.
Basically, we're not getting a new RDF resource for the inbox folder in the second profile, so we end up using the INBOX from the first profile, which has a pointer to the server from the first profile, and remembers the password in the wrong, old profile 1 server. The account manager doesn't have that server in its list anymore, so it doesn't clear out the password for that server. It doesn't have it in the list because we replaced it in the hash table of incoming servers. I think we need to clear out the rdf resources for these folders somehow - not sure how. The alternative is to clear the server field of all folders on shutdown in turbo mode.
Attached patch Proposed patch, v1 (deleted) — Splinter Review
Reset incoming server pointer in nsMsgFolder::Shutdown().
Comment on attachment 77755 [details] [diff] [review] Proposed patch, v1 R=ducarroz
Attachment #77755 - Flags: review+
Comment on attachment 77755 [details] [diff] [review] Proposed patch, v1 sr=bienvenu
Attachment #77755 - Flags: superreview+
Nominating for adt approval.
Keywords: adt1.0.0
Comment on attachment 77755 [details] [diff] [review] Proposed patch, v1 a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77755 - Flags: approval+
adt1.0.0+ (on ADT's behalf) approval for checkin into 1.0.
Keywords: adt1.0.0adt1.0.0+
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
this can't be tested yet due to new bug 136181 where we're not sure Quick Launch is really on
Depends on: 136181
using build 20020413 branch on winme this is fixed. (the one with the fix to bug 136181) I created 3 profiles while in Quick Launch added mail accounts to each of them with one mail account that was included in all three. I launched these three profiles randomly several times exiting before launching the next. I was prompted for each mail account as expected. Verified.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: