In bug 1317223 we would like to sort client engine records by "most recently synced" so we can choose the engine most likely to respond to commands. A reasonable approximation for this is the last-modified timestamp on the server record. This patch makes that time available in a serverLastModified field on the engine object. It is never written to the server and isn't exposed on *our* client record. It steals from the engine.lastSync attribute after uploading other records. I first named it simply "lastModified", but the semantics of that WRT queueing a new command vs upload of that new command was fuzzy, so renamed it to make it clearer.

mozreview got upset with me, so here it is

Comment on attachment 8841448 [details] [diff] [review] Bug_1342851___record_the_last_modified_time_of_a_Sync_client_record__r_rnewman.patch Review of attachment 8841448 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b8fb83d1d851 record the last-modified time of a Sync client record. r=rnewman

This was causing xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=80676915&repo=mozilla-inbound on some platforms, so I had to back it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3bc19b609193

(In reply to Wes Kocher (:KWierso) from comment #4) > This was causing xpcshell failures like Sorry about that - I had my patches in the wrong order - I'll reland via reviewboard, thanks!

Comment on attachment 8842398 [details] Bug 1342851 - record the last-modified time of a Sync client record. /me now battles reviewboard...

Comment on attachment 8842398 [details] Bug 1342851 - record the last-modified time of a Sync client record. https://reviewboard.mozilla.org/r/116264/#review117816 /me battles it from the other side...

Comment on attachment 8842398 [details] Bug 1342851 - record the last-modified time of a Sync client record. https://reviewboard.mozilla.org/r/116264/#review118010

Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/f0960b4bd9c4 record the last-modified time of a Sync client record. r=rnewman