Closed
Bug 1342937
Opened 8 years ago
Closed 8 years ago
Error out from |mach try| when using test paths if no config.status is detected
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
After bug 1320194, it is no longer an error to try to resolve tests without a build context.
Since |mach try| with test paths uses this test resolver, it means |mach try| can have unexpected behaviour without a full build backend. In the best case, it will could unexpectedly error out saying "no tests found". In the worst case, it could still push to try, but certain tasks the developer expected wouldn't show up.
This is only a problem if specifying test paths, e.g:
./mach try -b o -p linux -u mochitests dom/indexedDB
We should simply error out (like we did before bug 1320194) if no config.status is detected.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8841567 [details]
Bug 1342937 - Error out of |mach try| when using test paths and no build config is detected,
https://reviewboard.mozilla.org/r/115734/#review117282
Attachment #8841567 -
Flags: review?(cmanchester) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c1627e91713
Error out of |mach try| when using test paths and no build config is detected, r=chmanchester
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•