Closed
Bug 1342957
Opened 8 years ago
Closed 8 years ago
MOZ_ASSERT(true) in AnimationEffectReadOnly::GetComputedTimingAt
Categories
(Core :: DOM: Animation, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: bobowen, Assigned: boris)
References
Details
Attachments
(1 file)
:mak noticed this one when looking at bug 1342946, I assume this [1] should be MOZ_ASSERT(false, ...
[1] https://hg.mozilla.org/mozilla-central/file/106a96755d3b/dom/animation/AnimationEffectReadOnly.cpp#l237
|
Reporter | |
Updated•8 years ago
|
Flags: needinfo?(boris.chiou)
|
Assignee | |
Comment 1•8 years ago
|
||
Yes, you are right. We should fix this. Thanks for catching!
Flags: needinfo?(boris.chiou)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → boris.chiou
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8841626 [details]
Bug 1342957 - Fix incorrect MOZ_ASSERT in AnimationEffectReadOnly.
https://reviewboard.mozilla.org/r/115782/#review117230
Attachment #8841626 -
Flags: review?(hikezoe) → review+
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/682ee6f48027
Fix incorrect MOZ_ASSERT in AnimationEffectReadOnly. r=hiro
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•