Closed
Bug 1343275
Opened 8 years ago
Closed 8 years ago
Make the text control editor state's GetSelectionRange codepath a bit faster when going via the selection controller
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
We can get rid of some virtual calls and refcounting and stuff.
Assignee | ||
Comment 1•8 years ago
|
||
MozReview-Commit-ID: 2v0r3jtua1O
Attachment #8842046 -
Flags: review?(ehsan)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
MozReview-Commit-ID: 6NRoWNqb1pC
Attachment #8842047 -
Flags: review?(ehsan)
Updated•8 years ago
|
Attachment #8842046 -
Flags: review?(ehsan) → review+
Updated•8 years ago
|
Attachment #8842047 -
Flags: review?(ehsan) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fc55ce02ba5
part 1. Get selection faster in some nsTextEditorState methods. r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/32e54e6e8c02
part 2. Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range. r=ehsan
I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=82842964&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee52a1c26048
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 5•8 years ago
|
||
The issue is the patches for bug 1345237.
Assignee | ||
Comment 6•8 years ago
|
||
Er, bug 1343037.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5df501fbf40d
part 1. Get selection faster in some nsTextEditorState methods. r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1392f47637
part 2. Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range. r=ehsan
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(bzbarsky)
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5df501fbf40d
https://hg.mozilla.org/mozilla-central/rev/5b1392f47637
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•8 years ago
|
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•