Closed Bug 1343345 Opened 8 years ago Closed 7 years ago

Add runtime checking and disabling of WebRender if the environment doesn't support it

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected

People

(Reporter: kats, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Keywords: stale-bug, Whiteboard: [gfx-noted])

Right now if we run a webrender build on an environment that doesn't support it, we just crash on startup. We should do something more graceful, like fall back to the non-webrender codepath. Generally the crash happens because we fail to create a GL Context, such as in the dep bugs. Note that we now have an InitWebRenderConfig function at [1] and it would be swell if we checked the runtime environment either before or inside that function, and set the appropriate disable flag on the gfxFeature. [1] http://searchfox.org/mozilla-central/rev/4039fb4c5833706f6880763de216974e00ba096c/gfx/thebes/gfxPlatform.cpp#2302
Assignee: nobody → sotaro.ikeda.g
Depends on: 1354411
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Target Milestone: --- → mozilla57
We already support graceful fallback by bug 1354411 and Bug 1387920. If we want another way to detect support, it seems better to create another bug for it.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Priority: P1 → --
Whiteboard: [wr-mvp] [gfx-noted] → [gfx-noted]
You need to log in before you can comment on or make changes to this bug.