Closed
Bug 1343568
Opened 8 years ago
Closed 7 years ago
mach try doesn't support --upload-xdbs
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: mccr8, Assigned: sfink)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Oh. It's arguable whether mach try should specifically support this. --upload-xdbs is not processed by any try syntax parser. It relies on everything but mach try allowing arbitrary strings in the commit messages, even ones that being with "try:".
If this is not desireable for mach try, and I would certainly be sympathetic to that point of view, I am fine with changing my syntax to something less troublesome. --job-options=upload-xdbs perhaps?
Details:
The script that runs these builds in taskcluster grabs out the commit message and "parses" it on its own. Where parsing means grepping for the substring --upload-xdbs. Note that because this is not done via the try syntax parser, if I happen to fix this with the commit message "Replace --upload-xdbs with XXX", it will upload the xdbs for the mozilla-inbound hazard jobs spawned by that push. :-)
Reporter | ||
Comment 2•8 years ago
|
||
This is the patch I've been using to hack around this. It just always adds the message.
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8875331 -
Flags: review?(cmanchester)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8875333 -
Flags: review?(cmanchester)
Assignee | ||
Updated•7 years ago
|
Attachment #8875331 -
Attachment is obsolete: true
Attachment #8875331 -
Flags: review?(cmanchester)
Updated•7 years ago
|
Attachment #8875333 -
Flags: review?(cmanchester) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/296f060687f7
Add --upload-xdbs option to mach try, r=chmanchester
Comment 6•7 years ago
|
||
Thanks.
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•