Comment on attachment 8843174 [details] Bug 1344102 - Add a telemetry for xml:base on styled element. https://reviewboard.mozilla.org/r/116936/#review118566 r=me ::: dom/base/FragmentOrElement.cpp:393 (Diff revision 1) > elem = elem->GetParent(); > } while(elem); > > if (!baseAttrs.IsEmpty()) { > doc->WarnOnceAbout(nsIDocument::eXMLBaseAttribute); > + if (nsCOMPtr<nsStyledElement> styled = You could also just check IsSVGElement() || IsHTMLElement() || IsXULElement(). Might be faster and without const_cast.

Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/823956575ed2 Add a telemetry for xml:base on styled element. r=bz

Comment on attachment 8843174 [details] Bug 1344102 - Add a telemetry for xml:base on styled element. Approval Request Comment [Feature/Bug causing the regression]: not a regression [User impact if declined]: no, but we want to have more data for removing xml:base support [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no, but the probe added in bug 1340926 which is mostly identical thing has been landed in aurora for a while [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: it just adds another telemetry probe on top of what was added in bug 1340926. [String changes made/needed]: none

Comment on attachment 8843174 [details] Bug 1344102 - Add a telemetry for xml:base on styled element. Let's uplift this to aurora now so we get better data for 53 once it moves to beta.