Closed
Bug 1344107
Opened 8 years ago
Closed 8 years ago
Adding shouldComponentUpdate for all request-list-column-* components
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: rickychien, Assigned: rickychien)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-review-board-request
|
Details |
Performance is definitelly our top priority in netmonitor. See https://bugzilla.mozilla.org/show_bug.cgi?id=1308441#c64.
Adding shouldComponentUpdate check to reduce unnecessary component update when receiving irrelative props changes.
|
||
Updated•8 years ago
|
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
This patch only work on top of a series of patches in bug 1308441.
|
||
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
Priority: -- → P1
Whiteboard: [netmonitor] [triage] → [netmonitor]
|
|
||
Updated•8 years ago
|
Iteration: --- → 54.3 - Mar 6
Whiteboard: [netmonitor] → [netmonitor-reserve]
|
|
||
Comment 3•8 years ago
|
||
(In reply to Ricky Chien [:rickychien] from comment #2)
> This patch only work on top of a series of patches in bug 1308441.
It could be useful to land the refactoring-part of the bug 1308441 so,
this patch doesn't have to wait for react-virtualized.
I'll let you to decide.
Honza
|
|
Assignee | |
Comment 4•8 years ago
|
||
Oh, the current implementation has used shouldComponentUpdate for every column components http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/components/request-list-item.js#80-83.
My react-virtualized patch doesn't support that at the beginning and I'd prefer to put it back in this separate patch. As a result, this patch must depend on bug 1308441.
|
|
Assignee | |
Comment 5•8 years ago
|
||
Close this bug and this patch will merge in bug 1308441 to solve performance regression.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•8 years ago
|
No longer blocks: netmonitor-html
Iteration: 54.3 - Mar 6 → ---
Priority: P1 → --
Whiteboard: [netmonitor-reserve]
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8843189 -
Flags: review?(odvarko)
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•