Closed Bug 1344143 Opened 8 years ago Closed 8 years ago

Revert bug 1200494 before Android INTL disabling becomes effective

Categories

(Firefox for Android Graveyard :: Download Manager, defect)

Product:
Firefox for Android Graveyard
Component:
Download Manager
Version:
54 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed, firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(1 file)

Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494).
(deleted), text/x-review-board-request
mak
: review+
gchang
: approval-mozilla-aurora+
Details
Part 1 of bug 1200494 (https://hg.mozilla.org/mozilla-central/rev/e07ec12de6c0) needs to be backed out again before bug 1343744 hits Beta/Release, otherwise we'll break the downloads list (and xpcshell tests as well).
Assignee: nobody → jh+bugzilla
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1344543
I've tried disabling the Intl API on a try build to check that the downloadutils xpcshell tests still work as expected (since they previously weren't enabled), but I'm only getting a broken build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2526287a0ae6f91bf736c726d9f79d56c649e150
Comment on attachment 8847241 [details] Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494). https://reviewboard.mozilla.org/r/120242/#review122240
Attachment #8847241 - Flags: review?(mak77) → review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/b57650ab9be8 Backing out changeset e07ec12de6c0 (Bug 1200494). r=mak
Could you request uplift to aurora? Fennec 54 will still turn off ICU...
Flags: needinfo?(jh+bugzilla)
Comment on attachment 8847241 [details] Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494). Approval Request Comment [Feature/Bug causing the regression]: Bug 1343725 [User impact if declined]: Intl API is not coming to Beta/Release after all for the time being - without this patch, the download manager will be broken. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No. [Why is the change risky/not risky?]: Straight backout of bug 1200494 except for adjusted bug numbers for followup. [String changes made/needed]: none
Flags: needinfo?(jh+bugzilla)
Attachment #8847241 - Flags: approval-mozilla-aurora?
Maybe this needs marking as fixed for the uplift request to show up wherever it needs to show up?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
status-firefox55: --- → fixed
Comment on attachment 8847241 [details] Bug 1344143 - Backing out changeset e07ec12de6c0 (Bug 1200494). Backout changes to avoid breaking download manager. Aurora54+.
Attachment #8847241 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: --- → Firefox 55
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: