Closed
Bug 1344156
Opened 8 years ago
Closed 8 years ago
devtools reps: update bundle to v0.4.0
Categories
(DevTools :: Shared Components, enhancement, P3)
DevTools
Shared Components
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843236 [details]
Bug 1344156 - reps v0.4.0: update reps bundle from GitHub;
https://reviewboard.mozilla.org/r/117026/#review118680
Thanks for doing this.
Attachment #8843236 -
Flags: review?(ttromey) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c4a7cc50c77
reps v0.4.0: update reps bundle from GitHub;r=tromey
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Comment 6•8 years ago
|
||
Your commit reintroduced many version parameters to the type attribute of script elements.
Please do not add any new versioned scripts. See bug 1342144 for details.
Flags: needinfo?(jdescottes)
|
|
||
Updated•8 years ago
|
|
|
||
Comment 7•8 years ago
|
||
Oh, I should have filed an upstream issue on GitHub? Will do.
|
|
Assignee | |
Comment 8•8 years ago
|
||
Sorry about that.
Reps (and their tests) are now maintained on Github [1] and copied from there on a weekly basis. I forgot to check if modifications were made in mc before doing the last copy. We should have a script to check whether modifications were made between two releases. In the meantime, I'll update the Reps release process.
> Oh, I should have filed an upstream issue on GitHub? Will do.
Thanks, that would be great!
[1] https://github.com/devtools-html/reps
Flags: needinfo?(jdescottes)
|
|
Assignee | |
Comment 9•8 years ago
|
||
Created a PR on GitHub to fix this: https://github.com/devtools-html/reps/pull/111
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•