Julian Descottes [:jdescottes] Assignee
	Description • 8 years ago

      No description provided.

	Julian Descottes [:jdescottes] Assignee
	Comment 1 • 8 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f03d2bc6069bdb4a4038be9e165df7322d23f635

	Tom Tromey :tromey
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8843236 [details]
Bug 1344156 - reps v0.4.0: update reps bundle from GitHub;

https://reviewboard.mozilla.org/r/117026/#review118680

Thanks for doing this.

	Pulsebot
	Comment 4 • 8 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c4a7cc50c77
reps v0.4.0: update reps bundle from GitHub;r=tromey

	Carsten Book [:Tomcat]
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8c4a7cc50c77

	Masatoshi Kimura [:emk]
	Comment 6 • 8 years ago

Your commit reintroduced many version parameters to the type attribute of script elements.

Please do not add any new versioned scripts. See bug 1342144 for details.

	Masatoshi Kimura [:emk]
	Comment 7 • 8 years ago

Oh, I should have filed an upstream issue on GitHub? Will do.

	Julian Descottes [:jdescottes] Assignee
	Comment 8 • 8 years ago

Sorry about that. 

Reps (and their tests) are now maintained on Github [1] and copied from there on a weekly basis. I forgot to check if modifications were made in mc before doing the last copy. We should have a script to check whether modifications were made between two releases. In the meantime, I'll update the Reps release process.

> Oh, I should have filed an upstream issue on GitHub? Will do.

Thanks, that would be great!

[1] https://github.com/devtools-html/reps

	Julian Descottes [:jdescottes] Assignee
	Comment 9 • 8 years ago

Created a PR on GitHub to fix this: https://github.com/devtools-html/reps/pull/111