Open
Bug 1344243
Opened 8 years ago
Updated 2 years ago
Theming API - use a separate bootstrap script and flow for themes
Categories
(WebExtensions :: Themes, enhancement, P5)
WebExtensions
Themes
Tracking
(Not tracked)
NEW
People
(Reporter: mikedeboer, Unassigned)
References
Details
(Whiteboard: user-story, triaged)
In bug 1330349 Andrew mentioned - and Dave T. concurred - that we should use a different bootstrap mechanism for WebExtension Themes than the regular full-blown WebExtension one, using just `ExtensionData` and not `Extension` as a whole.
In practice that'd mean to start with using a new file 'ThemeExtensionBootstrap.js' instead of 'WebExtensionBootstrap.js' as we do now in XPIProvider.jsm
Reporter | ||
Comment 1•8 years ago
|
||
I don't this is terribly _hard_ (in: complicated) to do, but I'm interested in hearing the real benefits that'd justify this work. Adding a fork in the flow has a cost too - even though we may limit the amount of functionality we expose to theme WebExtensions (being a good thing).
If things like the L10n init are indeed costly enough, then that'd be a more than valid reason to add the fork.
Updated•7 years ago
|
Priority: -- → P5
Comment 2•7 years ago
|
||
mass move of existing themes bugs to new WebExtensions: Themes component
Component: WebExtensions: Frontend → WebExtensions: Themes
Comment 3•6 years ago
|
||
Hi Andrew,
With the recent refactorings Kris and you have done, is this still something that needs to be fixed ?
Flags: needinfo?(aswan)
Comment 4•6 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #3)
> With the recent refactorings Kris and you have done, is this still something
> that needs to be fixed ?
Yes, I think this would still be worthwhile.
Flags: needinfo?(aswan)
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Updated•6 years ago
|
Whiteboard: user-story, triaged → user-story, triaged, [ntim-intern-project]
Updated•6 years ago
|
Whiteboard: user-story, triaged, [ntim-intern-project] → user-story, triaged
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•