Closed Bug 1344294 Opened 8 years ago Closed 8 years ago

Update Frontend (3/3/2017)

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 3 obsolete files)

bundle3-3-3.patch
(deleted), patch
jlast
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → jlaster
Priority: -- → P3
Attached patch bundle3-3.patch (obsolete) (deleted) — — Splinter Review
Attachment #8843380 - Flags: review?(gtatum)
Attached patch bundle3-3-2.patch (obsolete) (deleted) — — Splinter Review
Attachment #8843380 - Attachment is obsolete: true
Attachment #8843380 - Flags: review?(gtatum)
Attachment #8843486 - Flags: review?(gtatum)
Comment on attachment 8843380 [details] [diff] [review] bundle3-3.patch Review of attachment 8843380 [details] [diff] [review]: ----------------------------------------------------------------- I did manual testing on a built version of the patch, and looked over the non-bundled files. Everything seems reasonable for a bundled landing. R+ with a clean try run.
Attachment #8843380 - Flags: review+
Attached patch bundle3-3-3.patch (obsolete) (deleted) — — Splinter Review
Attachment #8843486 - Attachment is obsolete: true
Attachment #8843486 - Flags: review?(gtatum)
Attachment #8843496 - Flags: review?(gtatum)
Attached patch bundle3-3-3.patch (deleted) — — Splinter Review
Attachment #8843496 - Attachment is obsolete: true
Attachment #8843496 - Flags: review?(gtatum)
Attachment #8843534 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1f2df690050b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Depends on: 1344820
Comment on attachment 8843534 [details] [diff] [review] bundle3-3-3.patch Review of attachment 8843534 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/debugger/new/index.html @@ +16,5 @@ > <link rel="stylesheet" type="text/css" href="resource://devtools/client/debugger/new/debugger.css" /> > </head> > <body> > <div id="mount"></div> > + <script type="application/javascript;version=1.8" Why did you add a version parameter back? We should not use versioned JavaScript anymore (see bug 1342144 for details).
See comment #10.
Flags: needinfo?(jlaster)
Sorry, that's being tracked here - http://github.com/devtools-html/debugger.html which i can remove
Flags: needinfo?(jlaster)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: