Closed
Bug 1344615
Opened 8 years ago
Closed 8 years ago
Remove nsXPCOMStrings.h/cpp after bug 1332639
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(2 files)
After bug 1332639 these files are mostly dead code: many of the functions operate on nsStringContainer, which is no longer defined.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Comment on attachment 8843829 [details]
Bug 1344615: Rewrite a few straggling users of NS_String* APIs.
https://reviewboard.mozilla.org/r/117434/#review119052
::: intl/unicharutil/util/nsUnicharUtils.cpp:69
(Diff revision 1)
> nsAString& aDest)
> {
> - const char16_t *in;
> - char16_t *out;
> - uint32_t len = NS_StringGetData(aSource, &in);
> - NS_StringGetMutableData(aDest, len, &out);
> + const char16_t *in = aSource.BeginReading();
> + uint32_t len = aSource.Length();
> +
> + aDest.SetLength(len);
(Yes, this is infallible.)
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843829 [details]
Bug 1344615: Rewrite a few straggling users of NS_String* APIs.
https://reviewboard.mozilla.org/r/117434/#review119356
Attachment #8843829 -
Flags: review?(benjamin) → review+
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843830 [details]
Bug 1344615: Remove nsXPCOMStrings.{h,cpp}
https://reviewboard.mozilla.org/r/117436/#review119358
woot
Attachment #8843830 -
Flags: review?(benjamin) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5973f50d866
Rewrite a few straggling users of NS_String* APIs. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/3733b20177e3
Remove nsXPCOMStrings.{h,cpp} r=bsmedberg
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d5973f50d866
https://hg.mozilla.org/mozilla-central/rev/3733b20177e3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•