Closed Bug 1344833 Opened 8 years ago Closed 8 years ago

Enable flake8 rule E128: "continuation line under-indented for visual indent"

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: Dexter, Assigned: fedepad, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=python])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1344832 +++ In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems. This bug is about enabling the E128 rule: "continuation line under-indented for visual indent" 1) Remove the E128 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry 2) Run "./mach lint -l flake8 toolkit/components/telemetry". 3) Fix the reported problems
No longer depends on: 1344832
Blocks: 1344834
No longer blocks: 1344834
Keywords: good-first-bug
Done, tests passed (./mach test). Submitted for review.
Assignee: nobody → federico_padua
Comment on attachment 8846918 [details] Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent". https://reviewboard.mozilla.org/r/119938/#review123658 This looks good to me, thanks. This will probably need to be rebased once 1344836 lands. Once you rebased, could you please check that linting is still reporting no error?
Attachment #8846918 - Flags: review?(alessio.placitelli) → review+
Comment on attachment 8846918 [details] Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent". https://reviewboard.mozilla.org/r/119938/#review123658 Yes, it will need to be rebased... Sure, I will re-check because I expect that with some of the modifications done by the "Enable flake8 rule" series that have been landing recently there might be the need to re-adjust something for this to report no linting errors.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 09e3abb5c142 -d 42e118e10c22: rebasing 382869:09e3abb5c142 "Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent". r=Dexter" (tip) merging toolkit/components/telemetry/.flake8 merging toolkit/components/telemetry/histogram_tools.py warning: conflicts while merging toolkit/components/telemetry/.flake8! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Looks like this needs to be rebased, again. Darn flake8!
Comment on attachment 8846918 [details] Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent". https://reviewboard.mozilla.org/r/119938/#review123658 Rebased again, so you should be able to merge now...I hope ;)
Pushed by alessio.placitelli@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0c20d53a06dc Enable flake8 rule E128: "continuation line under-indented for visual indent". r=Dexter
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: