Closed
Bug 1344846
Opened 8 years ago
Closed 8 years ago
Enable flake8 rule E203: "whitespace before ':'"
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: Dexter, Assigned: djmdeveloper060796, Mentored)
References
Details
(Whiteboard: [measurement:client][lang=python])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1344844 +++
In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.
This bug is about enabling the E203, "whitespace before ':'":
1) Remove the E203 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry
2) Run "./mach lint -l flake8 toolkit/components/telemetry".
3) Fix the reported problems
|
Assignee | |
Comment 1•8 years ago
|
||
Removed whitespace present before :, test is passing.
Attachment #8845499 -
Flags: review?(alessio.placitelli)
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → djmdeveloper060796
|
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8845499 [details] [diff] [review]
bug1344846.patch
Review of attachment 8845499 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, thanks.
However, this doesn't apply cleanly to the most recent mozilla-central. Please rebase your patch.
Attachment #8845499 -
Flags: review?(alessio.placitelli) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Updated my mozilla-central repo.
Attachment #8845499 -
Attachment is obsolete: true
Flags: needinfo?(alessio.placitelli)
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8845666 -
Flags: review+
|
|
Reporter | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3749bd0c914061acae85241cca2bf084f23b3d78
Bug 1344846 - Enable flake8 rule E203: "whitespace before ':'". r=dexter
|
|
Reporter | |
Updated•8 years ago
|
Flags: needinfo?(alessio.placitelli)
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•