Closed
Bug 1344850
Opened 8 years ago
Closed 8 years ago
Enable flake8 rule E202: "whitespace before '}'"
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: Dexter, Assigned: pauline.lallinec, Mentored)
References
Details
(Whiteboard: [measurement:client][lang=python])
Attachments
(1 file)
(deleted),
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1344849 +++
In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.
This bug is about enabling the E202, "whitespace before '}'":
1) Remove the E202 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry
2) Run "./mach lint -l flake8 toolkit/components/telemetry".
3) Fix the reported problems
Reporter | ||
Updated•8 years ago
|
Keywords: good-first-bug
Comment 1•8 years ago
|
||
I'd like to work on this issue. Could you please assign it to me? Thanks.
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Pooja Gadige (:pgadige) from comment #1)
> I'd like to work on this issue. Could you please assign it to me? Thanks.
Let's land the other bug you have assigned before taking on new work :)
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → shreab373
This bug may have been partially solved already because running "./mach lint -l flake8 toolkit/components/telemetry" after removing the rule E202 from the .flake8 file did not report any problem. I am therefore submitting a patch only for the update of the .flake8 file
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8853052 [details] [diff] [review]
Removed the E202 rule from the .flake8 file in source/toolkit/components/telemetry
Review of attachment 8853052 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, thanks!
Attachment #8853052 -
Flags: review+
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → pauline.lallinec
Status: NEW → ASSIGNED
Reporter | ||
Updated•8 years ago
|
Keywords: good-first-bug → checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f0467f930f
Remove the E202 rule from the .flake8 file in source/toolkit/components/telemetry. r=Dexter
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•8 years ago
|
status-firefox54:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•