Closed Bug 1344855 Opened 8 years ago Closed 8 years ago

Enable flake8 rule F401: "XXX imported but unused"

Categories

(Toolkit :: Telemetry, enhancement, P3)

Product:
Toolkit
Component:
Telemetry
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: Dexter, Assigned: fionn_mac, Mentored)

References

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 file)

Initial patch for Bug 1344855
(deleted), patch
Dexter
: review+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1344854 +++ In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems. This bug is about enabling the F401, "XXX imported but unused": 1) Remove the F401 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry 2) Run "./mach lint -l flake8 toolkit/components/telemetry". 3) Fix the reported problems
No longer depends on: 1344854
Blocks: 1344858
No longer blocks: 1344858
Hello! I'd like to work on this bug. I'll start work ASAP!
Assignee: nobody → vedant.sareen
Attached patch Initial patch for Bug 1344855 (deleted) — — Splinter Review
Attachment #8845531 - Flags: review?(alessio.placitelli)
Attachment #8845531 - Flags: review?(alessio.placitelli) → review+
https://hg.mozilla.org/mozilla-central/rev/188f56bfe47d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: