Closed
Bug 1344892
Opened 8 years ago
Closed 8 years ago
Let native calls dispatch to XPCOM event queue
Categories
(Core Graveyard :: Widget: Android, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(4 files, 4 obsolete files)
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Right now all native calls dispatch to the widget event queue in nsAppShell using the | dispatchTo = "gecko" | option. However, for many situations we want to dispatch to the XPCOM event queue in nsThread. Bug 1337910 was one case where we should have dispatched to the XPCOM event queue.
Assignee | ||
Comment 1•8 years ago
|
||
Rename the original "gecko" option for dispatchTo to "gecko_widget", and
add a new "gecko_xpcom" option that dispatches calls to the XPCOM event
queue.
Attachment #8844193 -
Flags: review?(snorp)
Assignee | ||
Comment 2•8 years ago
|
||
Update the existing dispatchTo = "gecko" options to either "gecko_widget" or
"gecko_xpcom". Most cases are updated to "gecko_xpcom" because the calls
interface directly with core Gecko code or may invoke JavaScript, which
requires the XPCOM event queue (bug 1337910). Most cases that use
"gecko_widget" involve UI events or JNI management calls like disposeNative.
Attachment #8844194 -
Flags: review?(snorp)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8844195 -
Flags: review+
Assignee | ||
Comment 4•8 years ago
|
||
Updated to have "gecko_priority" option in addition to old "gecko" option.
Attachment #8844529 -
Flags: review?(snorp)
Assignee | ||
Updated•8 years ago
|
Attachment #8844193 -
Attachment is obsolete: true
Attachment #8844193 -
Flags: review?(snorp)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8844530 -
Flags: review?(snorp)
Assignee | ||
Updated•8 years ago
|
Attachment #8844194 -
Attachment is obsolete: true
Attachment #8844194 -
Flags: review?(snorp)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8844532 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Attachment #8844195 -
Attachment is obsolete: true
Comment on attachment 8844529 [details] [diff] [review]
1. Add option to dispatch to priority queue (v2)
Review of attachment 8844529 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/annotation/WrapForJNI.java
@@ +30,5 @@
>
> /**
> * Action to take if member access returns an exception.
> + * - "abort" will cause a crash if there is a pending exception.
> + * - "ignore" will not handle any pending exceptions; it is then the caller's
Thanks, I for one was clearly confused about the definition on this one.
Attachment #8844529 -
Flags: review?(snorp) → review+
Attachment #8844530 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffeffef36f34
Let native calls dispatch to XPCOM event queue; r=snorp
Comment 9•8 years ago
|
||
Backed out on jchen's request for unexpected passes and fails with Android reftests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a986886241cb0aa08ca8a6b2ef9fd2bca6c0042
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=72479abe01240e9a7a4f49dca9abf2d84b264f74&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=83110685&repo=mozilla-inbound
> REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/image/test/reftest/downscaling/downscale-2a.html?203,52,left != about:blank | image comparison
Flags: needinfo?(nchen)
Assignee | ||
Comment 10•8 years ago
|
||
Updated patch that passes reftests. I think the reftest harness relies on some
specific timing between the attachToJava call in LayerView.Compositor and some
other messages.
Attachment #8847290 -
Flags: review+
Comment 11•8 years ago
|
||
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f5a93b89b2b
Let native calls dispatch to XPCOM event queue; r=snorp
Comment 12•8 years ago
|
||
sorry had to back this out for mochitest rc4 frequency failures like https://treeherder.mozilla.org/logviewer.html#?job_id=83917819&repo=mozilla-inbound&lineNumber=1776
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&bugfiler&noautoclassify&filter-searchStr=android%204.3%20api15%2B%20tc-m(rc4)&fromchange=141d25bf6372bc0fe2e42d4142d827a0c804ac0d&fromchange=c4b1bf7ab479&tochange=3e129df4d428
https://hg.mozilla.org/integration/mozilla-inbound/rev/6628c9503e36
Assignee | ||
Comment 13•8 years ago
|
||
Updated patch that makes GeckoThread.waitOnGecko wait for both queues to flush.
Assignee | ||
Updated•8 years ago
|
Attachment #8847290 -
Attachment is obsolete: true
Comment 14•8 years ago
|
||
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caf3e7f1f230
Let native calls dispatch to XPCOM event queue; r=snorp
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(nchen)
Comment 15•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•