Closed
Bug 1345034
Opened 8 years ago
Closed 8 years ago
Label runnables in dom/media/WMFMediaDataDecoder.cpp
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kaku, Assigned: kaku)
References
Details
(Whiteboard: [QDL][TDC-MVP][MEDIA])
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8844354 [details]
Bug 1345034 - Label runnables in dom/media/WMFMediaDataDecoder.cpp;
https://reviewboard.mozilla.org/r/117844/#review119502
::: dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:67
(Diff revision 1)
> }
>
> - nsCOMPtr<nsIRunnable> runnable = NS_NewRunnableFunction(
> + SystemGroup::Dispatch("WMFMediaDataDecoder::SendTelemetry",
> + TaskCategory::Other,
> + NS_NewRunnableFunction(
> - [sample] {
> + [sample] {
2-space indentation or store the return value of NS_NewRunnableFunction() in a temp so it is easier to align the code.
Please also open new bugs to label runnables involing Telemetry.
Attachment #8844354 -
Flags: review?(jwwang) → review+
|
|
Assignee | |
Updated•8 years ago
|
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•8 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/079e82b5210e
Label runnables in dom/media/WMFMediaDataDecoder.cpp; r=jwwang
Keywords: checkin-needed
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•8 years ago
|
Whiteboard: [QDL][TDC-MVP][MEDIA]
You need to log in
before you can comment on or make changes to this bug.
Description
•